On Sun, 16 Apr 2023 03:21:59 GMT, Michael Strauß wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Fix incorrect import
>> - Fix review comments
>
> modules/javafx.base/src/main/java/com/sun/javafx/binding/ArrayM
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> # Behavior
>
> |Listener...|ExpressionHelper|ListenerManager|
> |---|---|---|
> |Invocation Order|In order they were registered, invalidation listeners
> always before ch
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> # Behavior
>
> |Listener...|ExpressionHelper|ListenerManager|
> |---|---|---|
> |Invocation Order|In order they were registered, invalidation listeners
> always before ch
On Sat, 15 Apr 2023 18:01:28 GMT, Michael Strauß wrote:
>> This PR adds the following methods to the `EventTarget` interface:
>> 1. `addEventHandler`
>> 2. `removeEventHandler`
>> 3. `addEventFilter`
>> 4. `removeEventFilter`
>
> Michael Strauß has updated the pull request incrementally with one
On Sun, 16 Apr 2023 04:13:22 GMT, Michael Strauß wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Improve generics on ObservableValueBase
>> - Improve generics
>
> modules/javafx.base/src/main/java/javafx/beans/
On Sun, 16 Apr 2023 03:57:39 GMT, Michael Strauß wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Improve generics on ObservableValueBase
>> - Improve generics
>
> modules/javafx.base/src/main/java/com/sun/javaf
On Sun, 16 Apr 2023 03:59:09 GMT, Michael Strauß wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Improve generics on ObservableValueBase
>> - Improve generics
>
> modules/javafx.base/src/main/java/com/sun/javaf
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> # Behavior
>
> |Listener...|ExpressionHelper|ListenerManager|
> |---|---|---|
> |Invocation Order|In order they were registered, invalidation listeners
> always before ch
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> # Behavior
>
> |Listener...|ExpressionHelper|ListenerManager|
> |---|---|---|
> |Invocation Order|In order they were registered, invalidation listeners
> always before ch
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> # Behavior
>
> |Listener...|ExpressionHelper|ListenerManager|
> |---|---|---|
> |Invocation Order|In order they were registered, invalidation listeners
> always before ch
On Sun, 16 Apr 2023 07:43:05 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/binding/OldValueCachingListenerList.java
>> line 101:
>>
>>> 99: * notification otherwise {@code false}
>>> 100: */
>>> 101: public boolean notifyListeners(ObservableValu
On Sun, 16 Apr 2023 12:34:44 GMT, John Hendrikx wrote:
>> I agree with you there, and I've been looking what would be a good way to
>> achieve this. I will take another look soon. My primary concern is that
>> this is a somewhat critical path, and I would want to ensure that it doesn't
>> ca
On Sun, 16 Apr 2023 17:20:08 GMT, Michael Strauß wrote:
>> While looking that code over to see if it could be merged without impacting
>> the general case, I discovered a small bug in the OldValueCaching version.
>> After I fixed it, the code was even more similar than it was already. The
>>
On Sun, 16 Apr 2023 12:34:43 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> # Behavior
>>
>> |Listener...|ExpressionHelper|ListenerManager|
>> |---|---|---|
>> |Invocation Order|In order
On Sat, 15 Apr 2023 18:01:28 GMT, Michael Strauß wrote:
>> This PR adds the following methods to the `EventTarget` interface:
>> 1. `addEventHandler`
>> 2. `removeEventHandler`
>> 3. `addEventFilter`
>> 4. `removeEventFilter`
>
> Michael Strauß has updated the pull request incrementally with one
> This PR adds the following methods to the `EventTarget` interface:
> 1. `addEventHandler`
> 2. `removeEventHandler`
> 3. `addEventFilter`
> 4. `removeEventFilter`
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
doc changes
--
On Mon, 17 Apr 2023 03:08:27 GMT, Nir Lisker wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> revert a change in Menu
>
> modules/javafx.controls/src/main/java/javafx/scene/control/TableColumnBase.java
> line 738
On Mon, 17 Apr 2023 04:51:03 GMT, Michael Strauß wrote:
> I don't know what "visual events" are, maybe input events?
I thought something like that too, including scroll and touch events. Maybe
@kevinrushforth knows.
> Anyway, the added value of this entire javadoc seems to be rather low, I'm
On Sat, 15 Apr 2023 01:36:48 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/TreeShowingExpression.java
>> line 44:
>>
>>> 42: * an observable form.
>>> 43: */
>>> 44: public class TreeShowingExpression extends ReadOnlyBooleanPropertyBase {
>>
>> Maybe
On Mon, 17 Apr 2023 05:05:48 GMT, Nir Lisker wrote:
>> I don't know what "visual events" are, maybe input events?
>> Anyway, the added value of this entire javadoc seems to be rather low, I'm
>> inclined to just remove it entirely.
>>
>> By the way, there's a great documentation of the JavaFX e
> This PR adds the following methods to the `EventTarget` interface:
> 1. `addEventHandler`
> 2. `removeEventHandler`
> 3. `addEventFilter`
> 4. `removeEventFilter`
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
doc changes
--
On Mon, 17 Apr 2023 06:00:19 GMT, Michael Strauß wrote:
>> This PR adds the following methods to the `EventTarget` interface:
>> 1. `addEventHandler`
>> 2. `removeEventHandler`
>> 3. `addEventFilter`
>> 4. `removeEventFilter`
>
> Michael Strauß has updated the pull request incrementally with one
22 matches
Mail list logo
