Since surrogate pairs are internally considered as 2 characters and text field
is null in `HitInfo` when `getInsertionIndex` is invoked from `TextFlow`, wrong
insertion index was returned.
Updated code to calculate insertion index in `getHitInfo` method of
`PrismTextLayout` class when `hitTest`
Some comments are inline.
I think this may be a good idea, but I would like to know more about the
use cases.
All I can think of is that it *may* be useful when you want to persist a
Scene (or the states involved); but as you're building the Scene
yourself, you should already be aware of how
These changes use base classes for custom properties where possible for the
`ExpressionHelper` logic (and in one case, all the bind logic as well) instead
of duplicating these each time. As the base classes receive far more scrutiny,
this should reduce bugs in these re-implementations.
> These changes use base classes for custom properties where possible for the
> `ExpressionHelper` logic (and in one case, all the bind logic as well)
> instead of duplicating these each time. As the base classes receive far more
> scrutiny, this should reduce bugs in these re-implementations.
Vote: YES
~Ambarish
On Fri, 7 Apr 2023 22:39:52 GMT, Kevin Rushforth wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Revert "Make intellij see :systemTests dependecies"
>>
>>This reverts commit dca7eab24958e1214147
+1 for this change.
This also has the nice side effect that EventFilter/-Handler can be e.g. added to the Dialog now.
I wonder if it makes sense to make to also make those methods final then. At least where we can do it without breaking anything.
-- Marius
Gesendet: Mittwoch, 12. April 20
I also think this would be a good change, after a little more looking at
the compatibility impacts. Given that it is binary compatible (we need
to verify that with some testing), and that the source incompatibility
is limited to overriding classes of the four identified classes, which
looks to
> The Robot implementation on Linux did not consult the current layout when
> mapping from a KeyCode to a hardware code. Internally it retrieved results
> for all the layouts but just picked the first one it saw leading to random
> effects. Though not part of the original bug report, the code al
On Fri, 14 Apr 2023 09:47:45 GMT, John Hendrikx wrote:
>> These changes use base classes for custom properties where possible for the
>> `ExpressionHelper` logic instead of duplicating these each time.
>
> John Hendrikx has refreshed the contents of this pull request, and previous
> commits hav
On Sat, 15 Apr 2023 00:04:03 GMT, Kevin Rushforth wrote:
>> John Hendrikx has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new
On Fri, 14 Apr 2023 09:47:45 GMT, John Hendrikx wrote:
>> These changes use base classes for custom properties where possible for the
>> `ExpressionHelper` logic instead of duplicating these each time.
>
> John Hendrikx has refreshed the contents of this pull request, and previous
> commits hav
On Sat, 15 Apr 2023 01:26:13 GMT, Michael Strauß wrote:
>> John Hendrikx has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new c
On Wed, 12 Apr 2023 18:19:11 GMT, Michael Strauß wrote:
> This PR adds the following methods to the `EventTarget` interface:
> 1. `addEventHandler`
> 2. `removeEventHandler`
> 3. `addEventFilter`
> 4. `removeEventFilter`
If we proceed with this, we will need a CSR that documents the
incompatibi
This PR adds the following methods to the `EventTarget` interface:
1. `addEventHandler`
2. `removeEventHandler`
3. `addEventFilter`
4. `removeEventFilter`
-
Commit messages:
- remove final modifier
- remove final modifier
- documentation changes
- add final modifiers in Dialog cla
On Wed, 12 Apr 2023 18:19:11 GMT, Michael Strauß wrote:
> This PR adds the following methods to the `EventTarget` interface:
> 1. `addEventHandler`
> 2. `removeEventHandler`
> 3. `addEventFilter`
> 4. `removeEventFilter`
This PR assumes that changing the first method signature to the second is a
16 matches
Mail list logo
