On Tue, 11 Apr 2023 01:36:48 GMT, Nir Lisker wrote:
> > Well, I am just following the specification here, but JavaFX itself isn't...
> > We may need to make a decision here. JavaFX is not consistent itself where
> > it applies `equals` and where it uses reference equality:
>
> Alright, so this
> Fixes three issues in ExpressionHelper:
>
> - Current Value was not retained when changing from SingleChange to Generic,
> this can lead to missed changes
> - Current Value was not retained when changing from Generic to SingleChange,
> this can lead to missed changes
> - Current Value was not
On Tue, 11 Apr 2023 07:57:56 GMT, John Hendrikx wrote:
>> Fixes three issues in ExpressionHelper:
>>
>> - Current Value was not retained when changing from SingleChange to Generic,
>> this can lead to missed changes
>> - Current Value was not retained when changing from Generic to SingleChange,
On Mon, 10 Apr 2023 23:55:51 GMT, Martin Fox wrote:
>> When processing a `WM_CHAR` event on an OEM key (punctuation, symbol, dead
>> key) the glass code will dynamically query the key's unshifted character to
>> determine the Java code to assign to it. This is necessary since the
>> relationsh
On Tue, 11 Apr 2023 07:57:56 GMT, John Hendrikx wrote:
>> Fixes three issues in ExpressionHelper:
>>
>> - Current Value was not retained when changing from SingleChange to Generic,
>> this can lead to missed changes
>> - Current Value was not retained when changing from Generic to SingleChange,
On Tue, 29 Jun 2021 14:20:30 GMT, Johan Vos wrote:
>> Make sure the returned fullName of a created font matches the requested
>> name. Since the name is used as a key/identifier in some cases, some
>> internal code relies on this.
>> Added a test to check the case of "System Font Regular" on Ma
On Tue, 29 Jun 2021 14:00:08 GMT, Johan Vos wrote:
> Make sure the returned fullName of a created font matches the requested name.
> Since the name is used as a key/identifier in some cases, some internal code
> relies on this.
> Added a test to check the case of "System Font Regular" on MacOS,
On Sat, 26 Jun 2021 15:40:47 GMT, Johan Vos wrote:
> [Mac only] register system fonts.
> Fix for JDK-8246104
>
> The list of available fonts returned by
> CTFontCollectionCreateFromAvailableFonts does not contain internal fonts (at
> least not by default, although this is not documented). By r
On Sat, 26 Jun 2021 15:40:47 GMT, Johan Vos wrote:
> [Mac only] register system fonts.
> Fix for JDK-8246104
>
> The list of available fonts returned by
> CTFontCollectionCreateFromAvailableFonts does not contain internal fonts (at
> least not by default, although this is not documented). By r
On Mon, 10 Apr 2023 08:32:33 GMT, Karthik P K wrote:
>> When custom skin was loaded, the listeners added in `ContextMenuContent`
>> class while loading the default skin were not removed. This was causing the
>> NPE when outdated listeners were invoked.
>>
>> Updated the code to dispose listene
On Thu, 30 Mar 2023 21:53:48 GMT, John Hendrikx wrote:
> Fixes three issues in ExpressionHelper:
>
> - Current Value was not retained when changing from SingleChange to Generic,
> this can lead to missed changes
> - Current Value was not retained when changing from Generic to SingleChange,
> t
On Mon, 10 Apr 2023 07:21:21 GMT, Ajit Ghaisas wrote:
>> Karthik P K has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add space between if and (
>> - Address review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/contro
> When custom skin was loaded, the listeners added in `ContextMenuContent`
> class while loading the default skin were not removed. This was causing the
> NPE when outdated listeners were invoked.
>
> Updated the code to dispose listeners in the `dispose` method of
> `ContextMenuSkin` so that w
On Tue, 11 Apr 2023 12:18:52 GMT, Karthik P K wrote:
>> When custom skin was loaded, the listeners added in `ContextMenuContent`
>> class while loading the default skin were not removed. This was causing the
>> NPE when outdated listeners were invoked.
>>
>> Updated the code to dispose listene
Clean Backport.This pull request contains a backport of commit
[935c7b79](https://github.com/openjdk/jfx/commit/935c7b797d79407d741735324313684617d1292d)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
-
Commit messages:
- Backport 935c7b797d79407d741735324313684617
On Tue, 11 Apr 2023 17:03:51 GMT, Hima Bindu Meda wrote:
> Clean Backport.This pull request contains a backport of commit
> [935c7b79](https://github.com/openjdk/jfx/commit/935c7b797d79407d741735324313684617d1292d)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
This pull req
On Mon, 10 Apr 2023 23:08:31 GMT, John Hendrikx wrote:
>> BitSet uses the SetListenerHelper abstraction to prevent allocating the
>> listener arrays.
>>
>> When removing listeners, the newly returned listener helper (which may be
>> different from the one called) is not reassigned. This effect
On Thu, 23 Dec 2021 20:50:53 GMT, Martin Fox wrote:
> When processing a `WM_CHAR` event on an OEM key (punctuation, symbol, dead
> key) the glass code will dynamically query the key's unshifted character to
> determine the Java code to assign to it. This is necessary since the
> relationship b
On Tue, 11 Apr 2023 18:27:51 GMT, Andy Goryachev wrote:
> too late, but this code gives off 2 warnings:
The warnings are from Eclipse? The signature of this method matches the
interface method from `Set` so the warnings are surprising. If you think it's a
legitimate warning, then can you file
On Mon, 10 Apr 2023 23:08:31 GMT, John Hendrikx wrote:
>> BitSet uses the SetListenerHelper abstraction to prevent allocating the
>> listener arrays.
>>
>> When removing listeners, the newly returned listener helper (which may be
>> different from the one called) is not reassigned. This effect
On Wed, 13 Oct 2021 10:52:40 GMT, Fabian Wolter wrote:
> There are sometimes multitouch events detected, when only a single touch
> should be detected under certain conditions. This lead to touch events on
> previous touch positions.
>
> The referenced bug is closed with "won't fix" with the j
Fixed minor warnings in Eclipse.
-
Commit messages:
- 8305867: BitSetShim: The type parameter T is hiding the type T warning
Changes: https://git.openjdk.org/jfx/pull/1086/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1086&range=00
Issue: https://bugs.openjdk.org/browse/
On Tue, 11 Apr 2023 20:46:37 GMT, Andy Goryachev wrote:
> Fixed minor warnings in Eclipse.
Marked as reviewed by jhendrikx (Committer).
-
PR Review: https://git.openjdk.org/jfx/pull/1086#pullrequestreview-1380481855
> When custom skin was loaded, the listeners added in `ContextMenuContent`
> class while loading the default skin were not removed. This was causing the
> NPE when outdated listeners were invoked.
>
> Updated the code to dispose listeners in the `dispose` method of
> `ContextMenuSkin` so that w
On Tue, 11 Apr 2023 15:04:27 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add space between if and (
>> - Address review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/cont
On Wed, 12 Apr 2023 05:08:46 GMT, Karthik P K wrote:
>> When custom skin was loaded, the listeners added in `ContextMenuContent`
>> class while loading the default skin were not removed. This was causing the
>> NPE when outdated listeners were invoked.
>>
>> Updated the code to dispose listene
26 matches
Mail list logo
