Integrated: 8088343: Race condition in javafx.concurrent.Task::cancel

2025-04-24 Thread Andy Goryachev
del; 10 mod 8088343: Race condition in javafx.concurrent.Task::cancel Reviewed-by: kcr, arapte - PR: https://git.openjdk.org/jfx/pull/1769

Re: RFR: 8088343: Race condition in javafx.concurrent.Task::cancel [v3]

2025-04-24 Thread Andy Goryachev
On Wed, 16 Apr 2025 20:28:14 GMT, Andy Goryachev wrote: >> The code should not set the `Task.state` value to `CANCELLED` if the said >> task is already `SUCCEEDED` or `FAILED`. >> >> This is a product bug. >> >> Added `@RepeatedTest(50)` to the tests that used to fail intermittently - >> this

Re: RFR: 8088343: Race condition in javafx.concurrent.Task::cancel [v3]

2025-04-24 Thread Ambarish Rapte
On Wed, 16 Apr 2025 20:28:14 GMT, Andy Goryachev wrote: >> The code should not set the `Task.state` value to `CANCELLED` if the said >> task is already `SUCCEEDED` or `FAILED`. >> >> This is a product bug. >> >> Added `@RepeatedTest(50)` to the tests that used to fail intermittently - >> this

Re: RFR: 8088343: Race condition in javafx.concurrent.Task::cancel [v3]

2025-04-23 Thread Andy Goryachev
On Wed, 16 Apr 2025 20:28:14 GMT, Andy Goryachev wrote: >> The code should not set the `Task.state` value to `CANCELLED` if the said >> task is already `SUCCEEDED` or `FAILED`. >> >> This is a product bug. >> >> Added `@RepeatedTest(50)` to the tests that used to fail intermittently - >> this

Re: RFR: 8088343: Race condition in javafx.concurrent.Task::cancel [v3]

2025-04-23 Thread Kevin Rushforth
On Wed, 16 Apr 2025 20:28:14 GMT, Andy Goryachev wrote: >> The code should not set the `Task.state` value to `CANCELLED` if the said >> task is already `SUCCEEDED` or `FAILED`. >> >> This is a product bug. >> >> Added `@RepeatedTest(50)` to the tests that used to fail intermittently - >> this

cancel

2023-08-01 Thread dms489
I have changed resouces. DMS -- David Smith david.sm...@dms489.com

Integrated: JDK-8090647: Mnemonics : on windows we should cancel the underscore latch when an app loses focus.

2023-03-07 Thread Pedro Duque Vieira
Hi, It's been a while (I've been on vacation, etc) but thank you very much for fixing this issue on such short notice! Thanks again, kind regards, -- Pedro Duque Vieira - https://www.pixelduke.com

Integrated: JDK-8090647: Mnemonics : on windows we should cancel the underscore latch when an app loses focus.

2023-02-22 Thread John Hendrikx
them when > returning This pull request has now been integrated. Changeset: 25e4ab90 Author:John Hendrikx URL: https://git.openjdk.org/jfx/commit/25e4ab90f498ae844fe5376b75ea6c5c229ff48e Stats: 31 lines in 2 files changed: 31 ins; 0 del; 0 mod 8090647: Mnemonics : on window

Re: RFR: JDK-8090647: Mnemonics : on windows we should cancel the underscore latch when an app loses focus. [v2]

2023-02-22 Thread Kevin Rushforth
On Wed, 15 Feb 2023 22:24:41 GMT, John Hendrikx wrote: >> This fix hides mnemonics when the Scene's Window loses focus. >> >> Before integration, we need to make sure this is correct behavior for Mac >> and Linux as well. It is correct for Windows. >> >> How to test: >> >> - Create a control

Re: RFR: JDK-8090647: Mnemonics : on windows we should cancel the underscore latch when an app loses focus. [v2]

2023-02-16 Thread Ajit Ghaisas
On Wed, 15 Feb 2023 22:24:41 GMT, John Hendrikx wrote: >> This fix hides mnemonics when the Scene's Window loses focus. >> >> Before integration, we need to make sure this is correct behavior for Mac >> and Linux as well. It is correct for Windows. >> >> How to test: >> >> - Create a control

Re: RFR: JDK-8090647: Mnemonics : on windows we should cancel the underscore latch when an app loses focus. [v2]

2023-02-15 Thread Andy Goryachev
On Wed, 15 Feb 2023 22:24:41 GMT, John Hendrikx wrote: >> This fix hides mnemonics when the Scene's Window loses focus. >> >> Before integration, we need to make sure this is correct behavior for Mac >> and Linux as well. It is correct for Windows. >> >> How to test: >> >> - Create a control

Re: RFR: JDK-8090647: Mnemonics : on windows we should cancel the underscore latch when an app loses focus. [v2]

2023-02-15 Thread John Hendrikx
> This fix hides mnemonics when the Scene's Window loses focus. > > Before integration, we need to make sure this is correct behavior for Mac and > Linux as well. It is correct for Windows. > > How to test: > > - Create a control with a mnemonic > - Alt-tab to another window (mnemonics appear w

Re: RFR: JDK-8090647: Mnemonics : on windows we should cancel the underscore latch when an app loses focus.

2023-02-15 Thread Andy Goryachev
On Sun, 12 Feb 2023 22:13:41 GMT, John Hendrikx wrote: > This fix hides mnemonics when the Scene's Window loses focus. > > Before integration, we need to make sure this is correct behavior for Mac and > Linux as well. It is correct for Windows. > > How to test: > > - Create a control with a m

Re: RFR: JDK-8090647: Mnemonics : on windows we should cancel the underscore latch when an app loses focus.

2023-02-15 Thread Martin Fox
On Sun, 12 Feb 2023 22:13:41 GMT, John Hendrikx wrote: > This fix hides mnemonics when the Scene's Window loses focus. > > Before integration, we need to make sure this is correct behavior for Mac and > Linux as well. It is correct for Windows. > > How to test: > > - Create a control with a m

Re: RFR: JDK-8090647: Mnemonics : on windows we should cancel the underscore latch when an app loses focus.

2023-02-15 Thread Kevin Rushforth
On Sun, 12 Feb 2023 22:13:41 GMT, John Hendrikx wrote: > This fix hides mnemonics when the Scene's Window loses focus. > > Before integration, we need to make sure this is correct behavior for Mac and > Linux as well. It is correct for Windows. > > How to test: > > - Create a control with a m

Re: RFR: JDK-8090647: Mnemonics : on windows we should cancel the underscore latch when an app loses focus.

2023-02-15 Thread Kevin Rushforth
On Sun, 12 Feb 2023 22:13:41 GMT, John Hendrikx wrote: > This fix hides mnemonics when the Scene's Window loses focus. > > Before integration, we need to make sure this is correct behavior for Mac and > Linux as well. It is correct for Windows. > > How to test: > > - Create a control with a m

Re: RFR: JDK-8090647: Mnemonics : on windows we should cancel the underscore latch when an app loses focus.

2023-02-15 Thread Andy Goryachev
On Sun, 12 Feb 2023 22:13:41 GMT, John Hendrikx wrote: > This fix hides mnemonics when the Scene's Window loses focus. > > Before integration, we need to make sure this is correct behavior for Mac and > Linux as well. It is correct for Windows. > > How to test: > > - Create a control with a m

RFR: JDK-8090647: Mnemonics : on windows we should cancel the underscore latch when an app loses focus.

2023-02-12 Thread John Hendrikx
This fix hides mnemonics when the Scene's Window loses focus. Before integration, we need to make sure this is correct behavior for Mac and Linux as well. It is correct for Windows. How to test: - Create a control with a mnemonic - Alt-tab to another window (mnemonics appear when alt is pressed