(I made a mistake and only replied to you, resending this email to the
mailing list and you)
> I've thought a bit about how we could have such a feature without
> introducing Stage appearance to the StyleTheme interface (I think the
> two concepts should remain separate).
> Here's the updated des
On Thu, Feb 2, 2023 at 12:14 AM Pedro Duque Vieira
wrote:
> The fact that a theme is either dark or light is strongly correlated to
> whether you as a developer want all window decorations to be light or dark.
> I'd say that very few use cases will want to have some windows to be light
> and ot
>
> 1) Ease of migration should be an important consideration, but there
> are also other considerations. I'd argue that getting the feature
> stacking and mental model right is more important, and giving themes a
> way to individually select if the stylesheets are user-agent or user
> stylesheets
On Tue, Jan 31, 2023 at 6:14 PM Pedro Duque Vieira
wrote:
> Thinking of existing themes migrating to this StyleTheme API (90% are
> implemented as author stylesheets), some visual glitches may start appearing
> for users of those themes once they start using the migrated versions (since
> they
My previous message seems to have perhaps gotten lost in the
various messages exchanged in this mailing list.. (just doing this small
comment so that my previous message doesn't get lost..)
It's getting very late here where I live, I will be back later tomorrow (a
few hours from now).
Thanks
On
Hi Michael,
Truly sorry for the late reply but haven't had time to reply sooner,
unfortunately..
2 -
> > I've been building javafx themes for years now. Started creating JMetro
> in JavaFX version 2. During this time I've been following how other themes
> are being built and I can say that about
Hi Andy,
see my comments below:
On Mon, Jan 23, 2023 at 10:33 PM Andy Goryachev
wrote:
>
> Let me backtrack a bit and ask a very specific question: what is the problem
> (or problems) you are trying to solve?
> I would like to understand if the problem exists (more on that below), does a
> wo
Subject: [External] : Re: Style themes API
Hi Andy!
please see my comments below:
On Fri, Jan 13, 2023 at 6:31 PM Andy Goryachev
wrote:
>
> #1 Theme
> I wonder if we need to clarify what we mean by the word "theme" in the
> context of a javaFX application. Are we talki
Hi Pedro,
see my comments below.
On Sat, Jan 21, 2023 at 5:19 PM Pedro Duque Vieira
wrote:
> I've been building javafx themes for years now. Started creating JMetro in
> JavaFX version 2. During this time I've been following how other themes are
> being built and I can say that about 90% of t
Hi again Michael,
2-
> Currently, the order of precedence is as follows (from highest to lowest):
> 1. Node.style
> 2. Parent.stylesheets
> 3. Scene.stylesheets
> 4. StyleableProperty values set from code
> 5. Application.styleTheme
> 6. Application.userAgentStylesheet
I understand you're sugge
Hi Pedro,
see my comments below.
On Mon, Jan 16, 2023 at 1:10 PM Pedro Duque Vieira
wrote:
>
> No problem, I mentioned those in my first comment but probably got lost in
> this conversation.
> 2 – I think the ability to specify in the StyleTheme whether it is a user
> agent stylesheet, or an a
Hi again Michael,
Thanks for taking the time to answer my comments.
As always, it's easier to comment on and criticize than to do the actual
work of implementing the feature. So thanks again for the patience.
My comments below:
I don't quite understand this. Can you elaborate on what the
> adva
My comments below:
On Sun, Jan 15, 2023 at 1:25 PM Pedro Duque Vieira
wrote:
>
> I think we could add that it has higher precedence than a user agent
> stylesheets but that's it's not an author stylesheet. We can also possibly
> briefly say what a user agent stylesheet and author stylesheet are
Hi Michael,
Thanks again for taking the time to answer my questions/comments and for
your efforts in coming forward with this new API proposal. And also thanks
for your patience as I can be a bit annoying at times. :)
There's of course a bunch of things I liked about your API proposal but for
the
Hi Pedro,
please see my comments below:
On Fri, Jan 13, 2023 at 10:06 PM Pedro Duque Vieira wrote:
>
> Hi all,
>
> I’ve seen in the mailing list a request for commenting on this PR and as a
> long-time theme developer (JMetro and other themes) I'd thought I'd give my 2
> cents.
>
> I think it
Hi Andy!
please see my comments below:
On Fri, Jan 13, 2023 at 6:31 PM Andy Goryachev
wrote:
>
> #1 Theme
> I wonder if we need to clarify what we mean by the word "theme" in the
> context of a javaFX application. Are we talking about colors, fonts,
> spacing, graphics, or all of the above?
Dear Michael:
Thank you for initiating this discussion and providing a pull request!
I would like to make a few comments and ask your opinion on some of the
difficulties the application developers face when confronted with requirements
to provide a custom styling or even a completely different
17 matches
Mail list logo
