On Thu, 16 Feb 2023 22:09:26 GMT, Kevin Rushforth wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8302355: checkFxUserThread(), adjusted javadoc accordingly. Added Tests
>
> modules/javafx.graphics/src/main/java
On Thu, 16 Feb 2023 18:54:18 GMT, Kevin Rushforth wrote:
>> @prrace What is your preference here?
>> Since `enterNestedEventLoop` and `exitNestedEventLoop` throw an exception
>> when not on the fx user thread, I feel like it makes sense to also add it
>> here as well.
>
> Phil's comment got me
On Thu, 16 Feb 2023 21:48:08 GMT, Marius Hanl wrote:
>> This PR adds the last missing method for dealing with nested event loops.
>> As also written in the ticket, there is currently no (public) way to find
>> out whether it is safe to start an event loop now or not.
>> Classes like `Dialog` che
On Wed, 15 Feb 2023 21:39:02 GMT, Kevin Rushforth wrote:
>> Should I also adjust the `Toolkit` javadoc or only the `Platform` one?
>
> It might be a good idea to also adjust the Toolkit docs; it doesn't get
> generated as javadoc, but could be useful for someone looking at the code. If
> you do
On Thu, 16 Feb 2023 18:25:23 GMT, Marius Hanl wrote:
>> So someone is asking a question when they call this.
>> Throwing an Exception could be considered an unfriendly way of answering it.
>> It only makes sense if you think the programmer will have enough information
>> to be sure that if S/HE
On Thu, 16 Feb 2023 03:45:28 GMT, Phil Race wrote:
>> It might be a good idea to also adjust the Toolkit docs; it doesn't get
>> generated as javadoc, but could be useful for someone looking at the code.
>> If you do, it wouldn't be part of the CSR, since Toolkit isn't API.
>
> So someone is as
> This PR adds the last missing method for dealing with nested event loops.
> As also written in the ticket, there is currently no (public) way to find out
> whether it is safe to start an event loop now or not.
> Classes like `Dialog` check via
> `Toolkit.getToolkit().canStartNestedEventLoop()`
