Re: RFR: 8359598: [TestBug] VirtualFlowTestUtils should not create a temporary Stage [v2]

2025-07-14 Thread Andy Goryachev
On Sat, 12 Jul 2025 10:35:23 GMT, Marius Hanl wrote: >> Currently, the VirtualFlowTestUtils used ONLY for tests has many utility >> methods to get and do something with the VirtualFlow of Virtualized Controls. >> >> It has one flaw: It may creates a temporary Stage with the StageLoader, when >

Re: RFR: 8359598: [TestBug] VirtualFlowTestUtils should not create a temporary Stage [v2]

2025-07-12 Thread Marius Hanl
On Thu, 10 Jul 2025 19:43:15 GMT, Andy Goryachev wrote: >> I thought about this as well. No strong opinion from my side. > > there should be no noise: it's more of a question of instructing the > developer why their test failed. if there is no message, the NPE will happen > in the context of t

Re: RFR: 8359598: [TestBug] VirtualFlowTestUtils should not create a temporary Stage [v2]

2025-07-12 Thread Marius Hanl
> Currently, the VirtualFlowTestUtils used ONLY for tests has many utility > methods to get and do something with the VirtualFlow of Virtualized Controls. > > It has one flaw: It may creates a temporary Stage with the StageLoader, when > the Control was never inside a Scene (and Stage) yet. This

Re: RFR: 8359598: [TestBug] VirtualFlowTestUtils should not create a temporary Stage

2025-07-10 Thread Andy Goryachev
On Sun, 15 Jun 2025 13:56:05 GMT, Marius Hanl wrote: > Currently, the VirtualFlowTestUtils used ONLY for tests has many utility > methods to get and do something with the VirtualFlow of Virtualized Controls. > > It has one flaw: It may creates a temporary Stage with the StageLoader, when > the

Re: RFR: 8359598: [TestBug] VirtualFlowTestUtils should not create a temporary Stage

2025-07-10 Thread Andy Goryachev
On Wed, 18 Jun 2025 10:43:38 GMT, Marius Hanl wrote: >> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/VirtualFlowTestUtils.java >> line 349: >> >>> 347: flow = (VirtualFlow)control.lookup("#virtual-flow"); >>> 348: >>> 349: if (sl != nul

Re: RFR: 8359598: [TestBug] VirtualFlowTestUtils should not create a temporary Stage

2025-07-10 Thread Alexander Zuev
On Wed, 18 Jun 2025 10:43:38 GMT, Marius Hanl wrote: >> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/VirtualFlowTestUtils.java >> line 349: >> >>> 347: flow = (VirtualFlow)control.lookup("#virtual-flow"); >>> 348: >>> 349: if (sl != nul

Re: RFR: 8359598: [TestBug] VirtualFlowTestUtils should not create a temporary Stage

2025-06-18 Thread Marius Hanl
On Mon, 16 Jun 2025 17:44:48 GMT, Andy Goryachev wrote: >> Currently, the VirtualFlowTestUtils used ONLY for tests has many utility >> methods to get and do something with the VirtualFlow of Virtualized Controls. >> >> It has one flaw: It may creates a temporary Stage with the StageLoader, when

Re: RFR: 8359598: [TestBug] VirtualFlowTestUtils should not create a temporary Stage

2025-06-16 Thread Andy Goryachev
On Sun, 15 Jun 2025 13:56:05 GMT, Marius Hanl wrote: > Currently, the VirtualFlowTestUtils used ONLY for tests has many utility > methods to get and do something with the VirtualFlow of Virtualized Controls. > > It has one flaw: It may creates a temporary Stage with the StageLoader, when > the