Re: RFR: 8356982: Update WebKit to 622.1 [v2]

2025-08-12 Thread Joeri Sykora
On Mon, 11 Aug 2025 14:57:00 GMT, Hima Bindu Meda wrote: >> This PR updates Webkit to v622.1. Verified sanity and build on Mac, Linux >> and windows platforms. No issue seen. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: >

Re: RFR: 8356982: Update WebKit to 622.1 [v2]

2025-08-12 Thread Joeri Sykora
On Sat, 9 Aug 2025 11:55:07 GMT, Joeri Sykora wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> additional fixes for webkit > > Successfully built on all major platforms. > @tiainen Could you please re-approve th

Re: RFR: 8356982: Update WebKit to 622.1 [v2]

2025-08-12 Thread Kevin Rushforth
On Mon, 11 Aug 2025 14:57:00 GMT, Hima Bindu Meda wrote: >> This PR updates Webkit to v622.1. Verified sanity and build on Mac, Linux >> and windows platforms. No issue seen. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: >

Re: RFR: 8356982: Update WebKit to 622.1 [v2]

2025-08-11 Thread Hima Bindu Meda
On Sat, 9 Aug 2025 11:55:07 GMT, Joeri Sykora wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> additional fixes for webkit > > Successfully built on all major platforms. @tiainen Could you please re-approve the

Re: RFR: 8356982: Update WebKit to 622.1 [v2]

2025-08-11 Thread Hima Bindu Meda
On Mon, 11 Aug 2025 21:43:02 GMT, Kevin Rushforth wrote: > All my testing looks good. The diffs look good as well, although I have one > pending question before I approve. > > As for the removal of the unused skia code, my question was really a comment: > this was removed because it is unused

Re: RFR: 8356982: Update WebKit to 622.1 [v2]

2025-08-11 Thread Jay Bhaskar
On Mon, 11 Aug 2025 21:40:08 GMT, Kevin Rushforth wrote: >> modules/javafx.web/src/main/native/Source/WebCore/Modules/compression/CompressionStreamEncoder.cpp >> line 91: >> >>> 89: return result != Z_OK && result != Z_STREAM_END && result != >>> Z_BUF_ERROR; >>> 90: #endif >>> 91: ret

Re: RFR: 8356982: Update WebKit to 622.1 [v2]

2025-08-11 Thread Kevin Rushforth
On Mon, 11 Aug 2025 14:57:00 GMT, Hima Bindu Meda wrote: >> This PR updates Webkit to v622.1. Verified sanity and build on Mac, Linux >> and windows platforms. No issue seen. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: >

Re: RFR: 8356982: Update WebKit to 622.1 [v2]

2025-08-11 Thread Kevin Rushforth
On Mon, 11 Aug 2025 15:25:28 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> additional fixes for webkit > > modules/javafx.web/src/main/native/Source/WebCore/Modules/compression/Compression

Re: RFR: 8356982: Update WebKit to 622.1 [v2]

2025-08-11 Thread Hima Bindu Meda
On Mon, 11 Aug 2025 15:24:47 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> additional fixes for webkit > > modules/javafx.web/src/main/native/Source/WebCore/Modules/compression/Compression

Re: RFR: 8356982: Update WebKit to 622.1 [v2]

2025-08-11 Thread Kevin Rushforth
On Mon, 11 Aug 2025 14:57:00 GMT, Hima Bindu Meda wrote: >> This PR updates Webkit to v622.1. Verified sanity and build on Mac, Linux >> and windows platforms. No issue seen. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: >

Re: RFR: 8356982: Update WebKit to 622.1 [v2]

2025-08-11 Thread Hima Bindu Meda
> This PR updates Webkit to v622.1. Verified sanity and build on Mac, Linux and > windows platforms. No issue seen. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: additional fixes for webkit - Changes: - all: http

Re: RFR: 8356982: Update WebKit to 622.1

2025-08-09 Thread Joeri Sykora
On Wed, 6 Aug 2025 17:51:44 GMT, Hima Bindu Meda wrote: > This PR updates Webkit to v622.1. Verified sanity and build on Mac, Linux and > windows platforms. No issue seen. Successfully built on all major platforms. - Marked as reviewed by sykora (Author). PR Review: https://git.o

Re: RFR: 8356982: Update WebKit to 622.1

2025-08-06 Thread Kevin Rushforth
On Wed, 6 Aug 2025 17:51:44 GMT, Hima Bindu Meda wrote: > This PR updates Webkit to v622.1. Verified sanity and build on Mac, Linux and > windows platforms. No issue seen. Reviewers: @kevinrushforth @jaybhaskar @tiainen - PR Comment: https://git.openjdk.org/jfx/pull/1865#issuecomm