On Wed, 18 Dec 2024 18:03:59 GMT, Andy Goryachev wrote:
>> Yes, that would make the callsite a bit easier. However, from an API
>> perspective, I think it's not the best approach to handle nulls in the
>> toolkit layer. A system that channels nulls thorugh various layers tends to
>> become har
On Sat, 14 Dec 2024 17:16:20 GMT, Michael Strauß wrote:
>> The `Paint` and `Material` classes can't be extended by user code, because
>> their implementations require special support in internal JavaFX code. The
>> classes should be sealed.
>
> Michael Strauß has updated the pull request increm
On Wed, 18 Dec 2024 17:55:12 GMT, Michael Strauß wrote:
>> this is not what I am asking though: in more than one place we have
>> _callers_ like this
>>
>> peer.setFillPaint(getFill() == null ? null : tk.getPaint(getFill()));
>>
>>
>> it could be changed to
>>
>> peer.setFillPaint(tk.getPai
On Sat, 14 Dec 2024 17:16:20 GMT, Michael Strauß wrote:
>> The `Paint` and `Material` classes can't be extended by user code, because
>> their implementations require special support in internal JavaFX code. The
>> classes should be sealed.
>
> Michael Strauß has updated the pull request increm
On Tue, 17 Dec 2024 18:18:00 GMT, Andy Goryachev wrote:
>> `null` is not a valid argument for this method, and has never been.
>> `acc_getPlatformPaint()` previously asserted that the return value is not
>> `null`.
>
> this is not what I am asking though: in more than one place we have _callers
On Tue, 17 Dec 2024 18:13:28 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/Toolkit.java line
>> 597:
>>
>>> 595:
>>> 596: public Object getPaint(Paint paint) {
>>> 597: return switch (paint) {
>>
>> standard warning: not equivalent change (i
On Tue, 17 Dec 2024 18:01:57 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> use exhaustive switch pattern
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/Toolkit.java line 597:
>
On Sat, 14 Dec 2024 17:16:20 GMT, Michael Strauß wrote:
>> The `Paint` and `Material` classes can't be extended by user code, because
>> their implementations require special support in internal JavaFX code. The
>> classes should be sealed.
>
> Michael Strauß has updated the pull request increm
On Sat, 14 Dec 2024 17:16:20 GMT, Michael Strauß wrote:
>> The `Paint` and `Material` classes can't be extended by user code, because
>> their implementations require special support in internal JavaFX code. The
>> classes should be sealed.
>
> Michael Strauß has updated the pull request increm
> The `Paint` and `Material` classes can't be extended by user code, because
> their implementations require special support in internal JavaFX code. The
> classes should be sealed.
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
10 matches
Mail list logo
