Re: RFR: 8345188: Support tree-structural pseudo-classes [v8]

2025-01-08 Thread Andy Goryachev
On Wed, 8 Jan 2025 19:24:33 GMT, Michael Strauß wrote: >> The CSS Selectors specification defines the `:root` pseudo-class that >> matches root nodes: >> https://www.w3.org/TR/selectors-4/#the-root-pseudo >> >> JavaFX uses the non-standard `.root` style class for the same purpose. We >> should

Re: RFR: 8345188: Support tree-structural pseudo-classes [v8]

2025-01-08 Thread Andy Goryachev
On Wed, 8 Jan 2025 22:27:03 GMT, John Hendrikx wrote: > I wouldn't think you'd see it in those cases as that would primarily be > hidden by the cost of adding all the children. I agree. Let me prototype something quickly - give me 10 minutes. - PR Comment: https://git.openjdk.org

Re: RFR: 8345188: Support tree-structural pseudo-classes [v8]

2025-01-08 Thread John Hendrikx
On Wed, 8 Jan 2025 20:23:15 GMT, Andy Goryachev wrote: > Anecdata: I did not see a noticeable performance difference on startup > between this PR and the master branch with 48 children with the monkey tester I wouldn't think you'd see it in those cases as that would primarily be hidden by the

Re: RFR: 8345188: Support tree-structural pseudo-classes [v8]

2025-01-08 Thread John Hendrikx
On Wed, 8 Jan 2025 19:52:21 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> move pseudo-class changes to end of onChanged > > modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssre

Re: RFR: 8345188: Support tree-structural pseudo-classes [v8]

2025-01-08 Thread Andy Goryachev
On Wed, 8 Jan 2025 19:24:33 GMT, Michael Strauß wrote: >> The CSS Selectors specification defines the `:root` pseudo-class that >> matches root nodes: >> https://www.w3.org/TR/selectors-4/#the-root-pseudo >> >> JavaFX uses the non-standard `.root` style class for the same purpose. We >> should

Re: RFR: 8345188: Support tree-structural pseudo-classes [v8]

2025-01-08 Thread Andy Goryachev
On Wed, 8 Jan 2025 19:24:33 GMT, Michael Strauß wrote: >> The CSS Selectors specification defines the `:root` pseudo-class that >> matches root nodes: >> https://www.w3.org/TR/selectors-4/#the-root-pseudo >> >> JavaFX uses the non-standard `.root` style class for the same purpose. We >> should

Re: RFR: 8345188: Support tree-structural pseudo-classes [v8]

2025-01-08 Thread Michael Strauß
> The CSS Selectors specification defines the `:root` pseudo-class that matches > root nodes: > https://www.w3.org/TR/selectors-4/#the-root-pseudo > > JavaFX uses the non-standard `.root` style class for the same purpose. We > should also support the `:root` pseudo-class for increased compatibil