Re: RFR: 8344067: TableCell indices may not match the TableRow index [v2]

2024-11-13 Thread Andy Goryachev
On Wed, 13 Nov 2024 20:02:01 GMT, Marius Hanl wrote: >> This PR fixes a bug where the `TableCell` indices can be outdated (not >> synchronized) with the `TableRow` index. >> >> What normally happens is: >> - Index is changed: Cell update is requested when the row is empty >> (otherwise noop) >

Re: RFR: 8344067: TableCell indices may not match the TableRow index [v2]

2024-11-13 Thread Andy Goryachev
On Wed, 13 Nov 2024 19:58:10 GMT, Marius Hanl wrote: >> (here and elsewhere) > > I usually keep it this way as it is still readable and less space. But > changed the formatting so that the statement with the dot `.filter` is in the > new line. This is as far as I know what most people do. ther

Re: RFR: 8344067: TableCell indices may not match the TableRow index [v2]

2024-11-13 Thread Marius Hanl
> This PR fixes a bug where the `TableCell` indices can be outdated (not > synchronized) with the `TableRow` index. > > What normally happens is: > - Index is changed: Cell update is requested when the row is empty (otherwise > noop) > - Item is changed: Cell update is requested, which will now

Re: RFR: 8344067: TableCell indices may not match the TableRow index [v2]

2024-11-13 Thread Marius Hanl
On Wed, 13 Nov 2024 18:10:49 GMT, Andy Goryachev wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewRowTest.java >> line 222: >> >>> 220: row.updateIndex(0); >>> 221: >>> 222: List> cells = >>> row.getChildrenUnmodifiable().stream(). >> >> mino