Re: RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX [v3]

2024-11-18 Thread Kevin Rushforth
On Mon, 18 Nov 2024 15:44:31 GMT, Andy Goryachev wrote: > The remaining AC/ACC in ios and android directories: Thanks. I filed [JDK-8344431](https://bugs.openjdk.org/browse/JDK-8344431) to track this. - PR Comment: https://git.openjdk.org/jfx/pull/1638#issuecomment-2483710461

Re: RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX [v3]

2024-11-18 Thread Andy Goryachev
On Sat, 16 Nov 2024 14:29:56 GMT, Kevin Rushforth wrote: >> This PR removes all remaining uses of `AccessController` and >> `AccessControlContext`, which represent the last remaining uses of the >> terminally deprecated security APIs except for those in the `/ios/` or >> `/android/` directorie

Re: RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX [v3]

2024-11-17 Thread Kevin Rushforth
> This PR removes all remaining uses of `AccessController` and > `AccessControlContext`, which represent the last remaining uses of the > terminally deprecated security APIs except for those in the `/ios/` or > `/android/` directories. > > With the removal of doPrivileged and the `if (System.ge

Re: RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX [v3]

2024-11-16 Thread Michael Strauß
On Sat, 16 Nov 2024 14:29:56 GMT, Kevin Rushforth wrote: >> This PR removes all remaining uses of `AccessController` and >> `AccessControlContext`, which represent the last remaining uses of the >> terminally deprecated security APIs except for those in the `/ios/` or >> `/android/` directorie

Re: RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX [v2]

2024-11-16 Thread Kevin Rushforth
On Thu, 14 Nov 2024 23:15:14 GMT, Michael Strauß wrote: >> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> additional comments > > modules/javafx.graphics/src/main/java/com/sun/javafx/tk/Toolkit.java line 375: > >> 373:

Re: RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX [v2]

2024-11-16 Thread Kevin Rushforth
On Thu, 14 Nov 2024 23:33:50 GMT, Andy Goryachev wrote: >> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> additional comments > > modules/javafx.web/src/main/java/com/sun/webkit/dom/JSObject.java line 45: > >> 43: /

Re: RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX [v2]

2024-11-14 Thread Andy Goryachev
On Thu, 14 Nov 2024 22:53:06 GMT, Kevin Rushforth wrote: >> This PR removes all remaining uses of `AccessController` and >> `AccessControlContext`, which represent the last remaining uses of the >> terminally deprecated security APIs except for those in the `/ios/` or >> `/android/` directorie

Re: RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX [v2]

2024-11-14 Thread Andy Goryachev
On Thu, 14 Nov 2024 23:45:51 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/Toolkit.java line 98: >> >>> 96: >>> 97: // Used as the (dummy) value for the various listener maps >>> 98: private static final Object dummyObj = new Object(); >> >> mino

Re: RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX [v2]

2024-11-14 Thread Michael Strauß
On Thu, 14 Nov 2024 23:11:23 GMT, Andy Goryachev wrote: >> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> additional comments > > modules/javafx.graphics/src/main/java/com/sun/javafx/tk/Toolkit.java line 98: > >> 96: >

Re: RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX [v2]

2024-11-14 Thread Michael Strauß
On Thu, 14 Nov 2024 22:53:06 GMT, Kevin Rushforth wrote: >> This PR removes all remaining uses of `AccessController` and >> `AccessControlContext`, which represent the last remaining uses of the >> terminally deprecated security APIs except for those in the `/ios/` or >> `/android/` directorie

Re: RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX [v2]

2024-11-14 Thread Kevin Rushforth
> This PR removes all remaining uses of `AccessController` and > `AccessControlContext`, which represent the last remaining uses of the > terminally deprecated security APIs except for those in the `/ios/` or > `/android/` directories. > > With the removal of doPrivileged and the `if (System.ge

Re: RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX

2024-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2024 20:59:16 GMT, Kevin Rushforth wrote: > This PR removes all remaining uses of `AccessController` and > `AccessControlContext`, which represent the last remaining uses of the > terminally deprecated security APIs except for those in the `/ios/` or > `/android/` directories. >