Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView [v6]

2025-06-03 Thread Ziad El Midaoui
On Tue, 3 Jun 2025 13:23:35 GMT, Ziad El Midaoui wrote: >> When the Root TreeItem is set to null, need to relayout to show the children >> items > > Ziad El Midaoui has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated ch

Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView [v6]

2025-06-03 Thread duke
On Tue, 3 Jun 2025 13:23:35 GMT, Ziad El Midaoui wrote: >> When the Root TreeItem is set to null, need to relayout to show the children >> items > > Ziad El Midaoui has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated ch

Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView [v6]

2025-06-03 Thread Andy Goryachev
On Tue, 3 Jun 2025 13:23:35 GMT, Ziad El Midaoui wrote: >> When the Root TreeItem is set to null, need to relayout to show the children >> items > > Ziad El Midaoui has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated ch

Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView [v6]

2025-06-03 Thread Ziad El Midaoui
On Tue, 3 Jun 2025 13:23:35 GMT, Ziad El Midaoui wrote: >> When the Root TreeItem is set to null, need to relayout to show the children >> items > > Ziad El Midaoui has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated ch

Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView [v6]

2025-06-03 Thread Ziad El Midaoui
> When the Root TreeItem is set to null, need to relayout to show the children > items Ziad El Midaoui has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains

Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView [v5]

2025-06-03 Thread Ambarish Rapte
On Tue, 3 Jun 2025 11:12:19 GMT, Ziad El Midaoui wrote: >> When the Root TreeItem is set to null, need to relayout to show the children >> items > > Ziad El Midaoui has updated the pull request incrementally with two > additional commits since the last revision: > > - Merge remote-tracking br

Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView [v5]

2025-06-03 Thread Ziad El Midaoui
> When the Root TreeItem is set to null, need to relayout to show the children > items Ziad El Midaoui has updated the pull request incrementally with two additional commits since the last revision: - Merge remote-tracking branch 'origin/8341281.RootTreeItem' into 8341281.RootTreeItem - Addi

Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView [v4]

2025-06-03 Thread Ziad El Midaoui
On Mon, 2 Jun 2025 15:38:04 GMT, Ambarish Rapte wrote: >> Ziad El Midaoui has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Minor change : new line added > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableViewSkin

Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView [v4]

2025-06-02 Thread Ambarish Rapte
On Tue, 27 May 2025 16:09:52 GMT, Ziad El Midaoui wrote: >> When the Root TreeItem is set to null, need to relayout to show the children >> items > > Ziad El Midaoui has updated the pull request incrementally with one > additional commit since the last revision: > > Minor change : new line

Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView [v4]

2025-05-28 Thread Ziad El Midaoui
On Tue, 27 May 2025 16:09:52 GMT, Ziad El Midaoui wrote: >> When the Root TreeItem is set to null, need to relayout to show the children >> items > > Ziad El Midaoui has updated the pull request incrementally with one > additional commit since the last revision: > > Minor change : new line

Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView [v4]

2025-05-27 Thread Andy Goryachev
On Tue, 27 May 2025 16:09:52 GMT, Ziad El Midaoui wrote: >> When the Root TreeItem is set to null, need to relayout to show the children >> items > > Ziad El Midaoui has updated the pull request incrementally with one > additional commit since the last revision: > > Minor change : new line

Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView [v2]

2025-05-27 Thread Ziad El Midaoui
> When the Root TreeItem is set to null, need to relayout to show the children > items Ziad El Midaoui has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains

Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView [v3]

2025-05-27 Thread Ziad El Midaoui
On Tue, 27 May 2025 15:43:23 GMT, Andy Goryachev wrote: >> Ziad El Midaoui has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Merge remote-tracking branch 'origin/8341281.RootTreeItem' into >> 8341281.RootTreeItem >> - Headfull Test add

Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView [v4]

2025-05-27 Thread Ziad El Midaoui
> When the Root TreeItem is set to null, need to relayout to show the children > items Ziad El Midaoui has updated the pull request incrementally with one additional commit since the last revision: Minor change : new line added - Changes: - all: https://git.openjdk.org/jfx/pul

Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView [v3]

2025-05-27 Thread Andy Goryachev
On Tue, 27 May 2025 14:03:15 GMT, Ziad El Midaoui wrote: >> When the Root TreeItem is set to null, need to relayout to show the children >> items > > Ziad El Midaoui has updated the pull request incrementally with two > additional commits since the last revision: > > - Merge remote-tracking

Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView [v3]

2025-05-27 Thread Ziad El Midaoui
> When the Root TreeItem is set to null, need to relayout to show the children > items Ziad El Midaoui has updated the pull request incrementally with two additional commits since the last revision: - Merge remote-tracking branch 'origin/8341281.RootTreeItem' into 8341281.RootTreeItem - Head

Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView

2025-04-28 Thread Kevin Rushforth
On Wed, 16 Apr 2025 16:49:44 GMT, Andy Goryachev wrote: >> When the Root TreeItem is set to null, need to relayout to show the children >> items > > if you merge the latest `master` branch it'll get rid of the build error on > windows. Reviewers: @andy-goryachev-oracle @arapte -

Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView

2025-04-16 Thread Andy Goryachev
On Thu, 10 Apr 2025 12:41:44 GMT, Ziad El Midaoui wrote: > When the Root TreeItem is set to null, need to relayout to show the children > items if you merge the latest `master` branch it'll get rid of the build error on windows. - PR Comment: https://git.openjdk.org/jfx/pull/176

Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView

2025-04-16 Thread Andy Goryachev
On Thu, 10 Apr 2025 12:41:44 GMT, Ziad El Midaoui wrote: > When the Root TreeItem is set to null, need to relayout to show the children > items Good job, the fix seems to be working. You can also try using the monkey tester to test various scenarios, I've updated it to include null values fo