Re: RFR: 8341164: Update boot JDK to 23

2024-10-03 Thread Kevin Rushforth
On Thu, 3 Oct 2024 08:24:18 GMT, Ambarish Rapte wrote: >> Running `gradle wrapper --gradle-version 8.10.2 >> --gradle-distribution-sha256-sum >> 31c55713e40233a8303827ceb42ca48a47267a0ad4bab9177123121e71524c26` on my >> Windows machine changes `gradlew` and `gradlew.bat` as follows: >> >> >>

Re: RFR: 8341164: Update boot JDK to 23

2024-10-03 Thread Ambarish Rapte
On Thu, 3 Oct 2024 06:23:06 GMT, Michael Strauß wrote: > Running `gradle wrapper --gradle-version 8.10.2 > --gradle-distribution-sha256-sum > 31c55713e40233a8303827ceb42ca48a47267a0ad4bab9177123121e71524c26` on my > Windows machine changes `gradlew` and `gradlew.bat` as follows: This is not o

Re: RFR: 8341164: Update boot JDK to 23

2024-10-03 Thread Joeri Sykora
On Wed, 2 Oct 2024 17:09:59 GMT, Ambarish Rapte wrote: > Update the boot JDK to version 23. > > Since Gradle 8.9 does not support JDK 23, it is necessary to upgrade Gradle > to the latest release, version 8.10.2, which supports JDK 23. > It is advised to upgrade directly to Gradle 8.10.2 rathe

Re: RFR: 8341164: Update boot JDK to 23

2024-10-02 Thread Michael Strauß
On Wed, 2 Oct 2024 17:09:59 GMT, Ambarish Rapte wrote: > Update the boot JDK to version 23. > > Since Gradle 8.9 does not support JDK 23, it is necessary to upgrade Gradle > to the latest release, version 8.10.2, which supports JDK 23. > It is advised to upgrade directly to Gradle 8.10.2 rathe

Re: RFR: 8341164: Update boot JDK to 23

2024-10-02 Thread Ambarish Rapte
On Wed, 2 Oct 2024 23:15:41 GMT, Kevin Rushforth wrote: > Doing this will ensure that gradlew and gradlew.bat are up-to-date with the > latest version, which is not the case for this PR. On a Mac machine, I had executed the command: `sh gradlew wrapper --gradle-version 8.10.2` It makes two cha

Re: RFR: 8341164: Update boot JDK to 23

2024-10-02 Thread Kevin Rushforth
On Wed, 2 Oct 2024 18:52:36 GMT, Michael Strauß wrote: > Gradle should be upgraded with the `wrapper` task (see [Upgrading your build > from Gradle 8.x to the > latest](https://docs.gradle.org/current/userguide/upgrading_version_8.html)): > > ``` > gradle wrapper --gradle-version 8.10.2 > ```

Re: RFR: 8341164: Update boot JDK to 23

2024-10-02 Thread Michael Strauß
On Wed, 2 Oct 2024 17:09:59 GMT, Ambarish Rapte wrote: > Update the boot JDK to version 23. > > Since Gradle 8.9 does not support JDK 23, it is necessary to upgrade Gradle > to the latest release, version 8.10.2, which supports JDK 23. > It is advised to upgrade directly to Gradle 8.10.2 rathe

Re: RFR: 8341164: Update boot JDK to 23

2024-10-02 Thread Kevin Rushforth
On Wed, 2 Oct 2024 17:09:59 GMT, Ambarish Rapte wrote: > Update the boot JDK to version 23. > > Since Gradle 8.9 does not support JDK 23, it is necessary to upgrade Gradle > to the latest release, version 8.10.2, which supports JDK 23. > It is advised to upgrade directly to Gradle 8.10.2 rathe

Re: RFR: 8341164: Update boot JDK to 23

2024-10-02 Thread Kevin Rushforth
On Wed, 2 Oct 2024 17:09:59 GMT, Ambarish Rapte wrote: > Update the boot JDK to version 23. > > Since Gradle 8.9 does not support JDK 23, it is necessary to upgrade Gradle > to the latest release, version 8.10.2, which supports JDK 23. > It is advised to upgrade directly to Gradle 8.10.2 rathe