On Tue, 13 Aug 2024 19:04:09 GMT, Alexander Matveev
wrote:
>> - libFFI updated to 3.4.6.
>> - No additional changes are done.
>> - Tested on Windows, macOS and Linux with all supported formats.
>
> Alexander Matveev has updated the pull request incrementally with one
> additional commit since t
On Tue, 13 Aug 2024 19:04:09 GMT, Alexander Matveev
wrote:
>> - libFFI updated to 3.4.6.
>> - No additional changes are done.
>> - Tested on Windows, macOS and Linux with all supported formats.
>
> Alexander Matveev has updated the pull request incrementally with one
> additional commit since t
> - libFFI updated to 3.4.6.
> - No additional changes are done.
> - Tested on Windows, macOS and Linux with all supported formats.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8336938: Update libFFI to 3.4.6 [v2]
---
On Tue, 13 Aug 2024 01:03:32 GMT, Alexander Matveev
wrote:
> Yes, it compiles fine. It was changed by libFFI itself in 3.4.6. I think to
> be inline with rest of comments in this file.
What I meant was that you missed making that change when you updated the file.
The old line with the inline
On Mon, 12 Aug 2024 23:15:58 GMT, Kevin Rushforth wrote:
> I see one minor difference between the upstream and your PR in a commented
> out line of code in `sysv_intel.S`. I don't know whether it is significant (I
> guess not, as long as it compiles with the current inline comment style).
>
>
On Wed, 7 Aug 2024 00:26:13 GMT, Alexander Matveev wrote:
> - libFFI updated to 3.4.6.
> - No additional changes are done.
> - Tested on Windows, macOS and Linux with all supported formats.
I see one minor difference between the upstream and your PR in a commented out
line of code in `sysv_inte
On Wed, 7 Aug 2024 00:26:13 GMT, Alexander Matveev wrote:
> - libFFI updated to 3.4.6.
> - No additional changes are done.
> - Tested on Windows, macOS and Linux with all supported formats.
@tiainen Do you want to be the second reviewer?
-
PR Comment: https://git.openjdk.org/jfx/pu
