Re: RFR: 8335630: Crash if Platform::exit called with fullScreen Stage on macOS 14 [v2]

2024-07-16 Thread Kevin Rushforth
> This PR solves two related bugs that are caused by events being delivered > while the FX runtime is in the process of shutting down. These bugs are > related enough that I think they need to be addressed at the same time. While > debugging and developing the test, I saw one or the other or bot

Re: RFR: 8335630: Crash if Platform::exit called with fullScreen Stage on macOS 14

2024-07-16 Thread Michael Strauß
On Mon, 15 Jul 2024 19:36:43 GMT, Kevin Rushforth wrote: > This PR solves two related bugs that are caused by events being delivered > while the FX runtime is in the process of shutting down. These bugs are > related enough that I think they need to be addressed at the same time. While > debug

Re: RFR: 8335630: Crash if Platform::exit called with fullScreen Stage on macOS 14

2024-07-16 Thread Kevin Rushforth
On Mon, 15 Jul 2024 23:31:43 GMT, Kevin Rushforth wrote: >>> since all accesses are happening on the FX app thread >> >> Not quite right: the following threads access the field, apart from JavaFX >> Application Thread: >> >> >> thread=JavaFX-Launcher >> thread=Thread-2 >> thread=PulseTimer-CV

Re: RFR: 8335630: Crash if Platform::exit called with fullScreen Stage on macOS 14

2024-07-15 Thread Kevin Rushforth
On Mon, 15 Jul 2024 23:03:10 GMT, Andy Goryachev wrote: >> This is unrelated to the current bug, since all accesses are happening on >> the FX app thread, so I'd like to file a follow-up to look into this. >> >> To answer the question, there might be a potential problem with other >> threads n

Re: RFR: 8335630: Crash if Platform::exit called with fullScreen Stage on macOS 14

2024-07-15 Thread Andy Goryachev
On Mon, 15 Jul 2024 22:53:52 GMT, Kevin Rushforth wrote: > since all accesses are happening on the FX app thread Not quite right: the following threads access the field, apart from JavaFX Application Thread: thread=JavaFX-Launcher thread=Thread-2 thread=PulseTimer-CVDisplayLink thread thread=

Re: RFR: 8335630: Crash if Platform::exit called with fullScreen Stage on macOS 14

2024-07-15 Thread Kevin Rushforth
On Mon, 15 Jul 2024 22:34:27 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/com/sun/glass/ui/View.java line 533: >> >>> 531: private boolean shouldHandleEvent() { >>> 532: // Don't send any more events if the application has shutdown >>> 533: if (Applicat

Re: RFR: 8335630: Crash if Platform::exit called with fullScreen Stage on macOS 14

2024-07-15 Thread Michael Strauß
On Mon, 15 Jul 2024 22:08:12 GMT, Andy Goryachev wrote: >> This PR solves two related bugs that are caused by events being delivered >> while the FX runtime is in the process of shutting down. These bugs are >> related enough that I think they need to be addressed at the same time. >> While de

Re: RFR: 8335630: Crash if Platform::exit called with fullScreen Stage on macOS 14

2024-07-15 Thread Andy Goryachev
On Mon, 15 Jul 2024 19:36:43 GMT, Kevin Rushforth wrote: > This PR solves two related bugs that are caused by events being delivered > while the FX runtime is in the process of shutting down. These bugs are > related enough that I think they need to be addressed at the same time. While > debug