On Tue, 25 Mar 2025 22:53:55 GMT, Ziad El Midaoui
wrote:
>> Added multi line prompt support for TextArea this will provide the ability
>> to have multiple lines in textArea as expected,
>> Also fixed tests to meet the new changes
>
> Ziad El Midaoui has updated the pull request incrementally wi
On Mon, 7 Apr 2025 15:14:52 GMT, Ziad El Midaoui wrote:
>> One thing I am curious about: I don't see a similar stripping of newlines in
>> the text itself for TextField, and yet it does render the whole string as if
>> the newline had been stripped. Do you know why we need to strip it from
>>
On Tue, 25 Mar 2025 22:53:55 GMT, Ziad El Midaoui
wrote:
>> Added multi line prompt support for TextArea this will provide the ability
>> to have multiple lines in textArea as expected,
>> Also fixed tests to meet the new changes
>
> Ziad El Midaoui has updated the pull request incrementally wi
On Fri, 28 Mar 2025 20:22:39 GMT, Kevin Rushforth wrote:
>> Option 1 is intentionally the status quo, and matches what Swing's
>> JComponent does, although @mstr2 is right that this isn't documented. An RFE
>> to treat `\r` or `\r\n` as a newline could be considered in the future. We
>> wouldn
On Fri, 28 Mar 2025 18:20:59 GMT, Kevin Rushforth wrote:
>> That doesn't sound like a compelling reason to me. In fact, it makes it
>> seems like a bug in JavaFX that a line break is only rendered with `\n`, but
>> not with `\r\n` or `\r`.
>>
>> In any case, the goal here is to (semantically)
On Wed, 26 Mar 2025 14:11:34 GMT, Michael Strauß wrote:
>> The tests show that only LF "\n" is rendered as a new line, there is no need
>> to add more restrictions that is not needed
>> and the same was tested by @andy-goryachev-oracle previously in the comments
>> and it confirms the same.
>
>
On Wed, 26 Mar 2025 14:11:34 GMT, Michael Strauß wrote:
>> The tests show that only LF "\n" is rendered as a new line, there is no need
>> to add more restrictions that is not needed
>> and the same was tested by @andy-goryachev-oracle previously in the comments
>> and it confirms the same.
>
>
On Wed, 26 Mar 2025 13:30:48 GMT, Ziad El Midaoui
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java
>> line 735:
>>
>>> 733: promptNode.fontProperty().bind(getSkinnable().fontProperty());
>>> 734:
>>> 735:
>>> promptNode.textProperty
On Wed, 26 Mar 2025 08:44:28 GMT, Michael Strauß wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed unused imports and code
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.
On Tue, 25 Mar 2025 22:53:55 GMT, Ziad El Midaoui
wrote:
>> Added multi line prompt support for TextArea this will provide the ability
>> to have multiple lines in textArea as expected,
>> Also fixed tests to meet the new changes
>
> Ziad El Midaoui has updated the pull request incrementally wi
On Tue, 25 Mar 2025 22:53:55 GMT, Ziad El Midaoui
wrote:
>> Added multi line prompt support for TextArea this will provide the ability
>> to have multiple lines in textArea as expected,
>> Also fixed tests to meet the new changes
>
> Ziad El Midaoui has updated the pull request incrementally wi
On Fri, 14 Mar 2025 16:27:09 GMT, Andy Goryachev wrote:
>> With the new approach the `promptText` property is accepting any value so
>> it's expected to have prompt text with Linebreaks for `TextField` and
>> `PasswordField`, is this the test that I have to keep ?
>>
>> Else to have a test tha
> Added multi line prompt support for TextArea this will provide the ability to
> have multiple lines in textArea as expected,
> Also fixed tests to meet the new changes
Ziad El Midaoui has updated the pull request incrementally with one additional
commit since the last revision:
Removed unus
13 matches
Mail list logo
