Re: RFR: 8335547: Support multi-line prompt text for TextArea [v2]

2025-04-05 Thread Ziad El Midaoui
> Added multi line prompt support for TextArea this will provide the ability to > have multiple lines in textArea as expected, > Also fixed tests to meet the new changes Ziad El Midaoui has updated the pull request incrementally with one additional commit since the last revision: changed wild

Re: RFR: 8335547: Support multi-line prompt text for TextArea [v2]

2025-03-24 Thread Ziad El Midaoui
On Fri, 21 Mar 2025 06:00:12 GMT, Michael Strauß wrote: >> You should consider using a fluent binding here, which is a more modern >> solution compared to the `Bindings` class. It is also simpler because you >> don't need to check for `null`: >> >> >> promptNode.textProperty().bind(getSkinnab

Re: RFR: 8335547: Support multi-line prompt text for TextArea [v2]

2025-03-22 Thread Andy Goryachev
On Fri, 21 Mar 2025 14:37:56 GMT, Ziad El Midaoui wrote: >> Added multi line prompt support for TextArea this will provide the ability >> to have multiple lines in textArea as expected, >> Also fixed tests to meet the new changes > > Ziad El Midaoui has updated the pull request incrementally wi

Re: RFR: 8335547: Support multi-line prompt text for TextArea [v2]

2025-03-21 Thread Andy Goryachev
On Fri, 21 Mar 2025 14:37:56 GMT, Ziad El Midaoui wrote: >> Added multi line prompt support for TextArea this will provide the ability >> to have multiple lines in textArea as expected, >> Also fixed tests to meet the new changes > > Ziad El Midaoui has updated the pull request incrementally wi

Re: RFR: 8335547: Support multi-line prompt text for TextArea [v2]

2025-03-21 Thread Ziad El Midaoui
On Thu, 20 Mar 2025 20:03:54 GMT, Andy Goryachev wrote: >> In tests, and especially for assertions, wildcard imports are usually >> accepted. We use them all over the place. However, I would agree that >> symbols other than assertions should usually be fully qualified. > > good point I kept th