Re: RFR: 8335218: Eclipse Config: Remove Gradle Integration

2024-07-09 Thread Andy Goryachev
On Wed, 26 Jun 2024 21:23:34 GMT, Andy Goryachev wrote: > This might be controversial. I am proposing to remove the Gradle integration > in the Eclipse config files. > > Problem > === > Eclipse Gradle integration (Buildship) cannot import the OpenJFX build.gradle > cleanly. Every time the

Re: RFR: 8335218: Eclipse Config: Remove Gradle Integration

2024-07-09 Thread John Hendrikx
On Wed, 26 Jun 2024 21:23:34 GMT, Andy Goryachev wrote: > This might be controversial. I am proposing to remove the Gradle integration > in the Eclipse config files. > > Problem > === > Eclipse Gradle integration (Buildship) cannot import the OpenJFX build.gradle > cleanly. Every time the

Re: RFR: 8335218: Eclipse Config: Remove Gradle Integration

2024-07-08 Thread Nir Lisker
On Wed, 26 Jun 2024 21:23:34 GMT, Andy Goryachev wrote: > This might be controversial. I am proposing to remove the Gradle integration > in the Eclipse config files. > > Problem > === > Eclipse Gradle integration (Buildship) cannot import the OpenJFX build.gradle > cleanly. Every time the

Re: RFR: 8335218: Eclipse Config: Remove Gradle Integration

2024-07-08 Thread Nir Lisker
On Mon, 8 Jul 2024 09:08:19 GMT, John Hendrikx wrote: > I work around this by running the test once, then changing its configuration > and adding a standard incantation to its command line (`-Djavafx.toolkit`, > `-Djava.library.path`, some `--add-modules`) The `--add-modules` could be taken c

Re: RFR: 8335218: Eclipse Config: Remove Gradle Integration

2024-07-08 Thread Andy Goryachev
On Sun, 7 Jul 2024 00:34:01 GMT, Nir Lisker wrote: >> This might be controversial. I am proposing to remove the Gradle integration >> in the Eclipse config files. >> >> Problem >> === >> Eclipse Gradle integration (Buildship) cannot import the OpenJFX >> build.gradle cleanly. Every time th

Re: RFR: 8335218: Eclipse Config: Remove Gradle Integration

2024-07-08 Thread Andy Goryachev
On Mon, 8 Jul 2024 09:08:19 GMT, John Hendrikx wrote: > What annoys me the most with the FX project is the inability to run certain > tests directly from the IDE by right clicking and selecting `Run as... JUnit > test`. Yep, same issue here, and same workaround. I wonder if it is possible to

Re: RFR: 8335218: Eclipse Config: Remove Gradle Integration

2024-07-08 Thread Andy Goryachev
On Mon, 8 Jul 2024 15:01:08 GMT, Lukasz Kostyra wrote: >> @lukostyra thank you for testing! there should be no changes made to the >> .project or any other files. could you reset your workspace and maybe try >> again? >> >> if the changes do appear, what are they? > >> if the changes do appe

Re: RFR: 8335218: Eclipse Config: Remove Gradle Integration

2024-07-08 Thread Lukasz Kostyra
On Fri, 5 Jul 2024 17:06:11 GMT, Andy Goryachev wrote: > if the changes do appear, what are they? @andy-goryachev-oracle I tried it again after clearing the workspace folder and they do appear again. I also had some old git index settings applied which hid most of .project changes. Turns out

Re: RFR: 8335218: Eclipse Config: Remove Gradle Integration

2024-07-08 Thread John Hendrikx
On Sun, 7 Jul 2024 00:34:01 GMT, Nir Lisker wrote: > Do you have any remarks? I personally don't launch build tools from the IDE (neither Gradle, nor Maven) but only use such tools to import projects; after the import I expect the IDE to be able to build and run tests without intervention of a

Re: RFR: 8335218: Eclipse Config: Remove Gradle Integration

2024-07-06 Thread Nir Lisker
On Wed, 26 Jun 2024 21:23:34 GMT, Andy Goryachev wrote: > This might be controversial. I am proposing to remove the Gradle integration > in the Eclipse config files. > > Problem > === > Eclipse Gradle integration (Buildship) cannot import the OpenJFX build.gradle > cleanly. Every time the

Re: RFR: 8335218: Eclipse Config: Remove Gradle Integration

2024-07-05 Thread Andy Goryachev
On Fri, 5 Jul 2024 13:42:58 GMT, Lukasz Kostyra wrote: >> This might be controversial. I am proposing to remove the Gradle integration >> in the Eclipse config files. >> >> Problem >> === >> Eclipse Gradle integration (Buildship) cannot import the OpenJFX >> build.gradle cleanly. Every tim

Re: RFR: 8335218: Eclipse Config: Remove Gradle Integration

2024-07-05 Thread Lukasz Kostyra
On Wed, 26 Jun 2024 21:23:34 GMT, Andy Goryachev wrote: > This might be controversial. I am proposing to remove the Gradle integration > in the Eclipse config files. > > Problem > === > Eclipse Gradle integration (Buildship) cannot import the OpenJFX build.gradle > cleanly. Every time the

Re: RFR: 8335218: Eclipse Config: Remove Gradle Integration

2024-06-26 Thread Kevin Rushforth
On Wed, 26 Jun 2024 21:23:34 GMT, Andy Goryachev wrote: > This might be controversial. I am proposing to remove the Gradle integration > in the Eclipse config files. > > Problem > === > Eclipse Gradle integration (Buildship) cannot import the OpenJFX build.gradle > cleanly. Every time the