Re: RFR: 8333275: ComboBox: adding an item from editor changes editor text [v2]

2025-02-07 Thread Kevin Rushforth
On Fri, 31 Jan 2025 19:18:17 GMT, Michael Strauß wrote: >> When the current editor value of a `ComboBox` is added to its items list, >> the editor value may be changed to an entirely unrelated item in the list. >> However, our expectation would be that the editor reflects the newly added >> it

Re: RFR: 8333275: ComboBox: adding an item from editor changes editor text [v2]

2025-01-31 Thread Andy Goryachev
On Fri, 31 Jan 2025 19:18:17 GMT, Michael Strauß wrote: >> When the current editor value of a `ComboBox` is added to its items list, >> the editor value may be changed to an entirely unrelated item in the list. >> However, our expectation would be that the editor reflects the newly added >> it

Re: RFR: 8333275: ComboBox: adding an item from editor changes editor text [v2]

2025-01-31 Thread Michael Strauß
> When the current editor value of a `ComboBox` is added to its items list, the > editor value may be changed to an entirely unrelated item in the list. > However, our expectation would be that the editor reflects the newly added > item instead. > > Under normal circumstances, adding items to t

Re: RFR: 8333275: ComboBox: adding an item from editor changes editor text [v2]

2025-01-31 Thread Michael Strauß
On Fri, 31 Jan 2025 17:27:47 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update copyright header > > modules/javafx.controls/src/main/java/javafx/scene/control/ListView.java line > 1315:

Re: RFR: 8333275: ComboBox: adding an item from editor changes editor text

2025-01-31 Thread Andy Goryachev
On Fri, 31 Jan 2025 02:37:42 GMT, Michael Strauß wrote: > When the current editor value of a `ComboBox` is added to its items list, the > editor value may be changed to an entirely unrelated item in the list. > However, our expectation would be that the editor reflects the newly added > item i