Re: RFR: 8332895: Support interpolation for backgrounds and borders [v26]

2024-09-03 Thread Michael Strauß
On Tue, 3 Sep 2024 02:27:10 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 48 additional >> commits

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v26]

2024-09-02 Thread John Hendrikx
On Sun, 1 Sep 2024 12:31:06 GMT, Michael Strauß wrote: >> This PR completes the CSS Transitions story (see #870) by adding >> interpolation support for backgrounds and borders, making them targetable by >> transitions. >> >> `Background` and `Border` objects are deeply immutable, but not >> i

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v26]

2024-09-02 Thread John Hendrikx
On Mon, 2 Sep 2024 16:24:33 GMT, Michael Strauß wrote: > Yes, it's a sizable chunk of the specification: > https://www.w3.org/TR/css-transitions-1/#starting Thanks, somehow I had trouble finding it. > The algorithm as prescribed by the specification is one of several algorithms > that were co

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v26]

2024-09-02 Thread Markus Mack
On Sun, 1 Sep 2024 12:31:06 GMT, Michael Strauß wrote: >> This PR completes the CSS Transitions story (see #870) by adding >> interpolation support for backgrounds and borders, making them targetable by >> transitions. >> >> `Background` and `Border` objects are deeply immutable, but not >> i

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v26]

2024-09-02 Thread Michael Strauß
On Mon, 2 Sep 2024 16:31:53 GMT, John Hendrikx wrote: > I've been looking at `TransitionMediator`s and `TransitionTimer`s -- these > two classes seem to always go together. There is some nasty bookkeeping going > on that requires clearing a reference of the mediator. I've had some success > ju

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v26]

2024-09-02 Thread John Hendrikx
On Sun, 1 Sep 2024 12:31:06 GMT, Michael Strauß wrote: >> This PR completes the CSS Transitions story (see #870) by adding >> interpolation support for backgrounds and borders, making them targetable by >> transitions. >> >> `Background` and `Border` objects are deeply immutable, but not >> i

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v26]

2024-09-02 Thread Michael Strauß
On Mon, 2 Sep 2024 15:37:38 GMT, John Hendrikx wrote: > Q1: I see a lot of work in the code to handle reverse transitions. Is this > actually part of the CSS specification? Yes, it's a sizable chunk of the specification: https://www.w3.org/TR/css-transitions-1/#starting > Q2: Reversal detect

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v26]

2024-09-02 Thread John Hendrikx
On Sun, 1 Sep 2024 12:31:06 GMT, Michael Strauß wrote: >> This PR completes the CSS Transitions story (see #870) by adding >> interpolation support for backgrounds and borders, making them targetable by >> transitions. >> >> `Background` and `Border` objects are deeply immutable, but not >> i

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v26]

2024-09-01 Thread Michael Strauß
> This PR completes the CSS Transitions story (see #870) by adding > interpolation support for backgrounds and borders, making them targetable by > transitions. > > `Background` and `Border` objects are deeply immutable, but not > interpolatable. Consider the following `Background`, which descr