Re: RFR: 8318204: Use new EventTarget methods in ListenerHelper

2023-10-18 Thread Nir Lisker
On Tue, 17 Oct 2023 14:27:19 GMT, Andy Goryachev wrote: > it's a functional interface, so no gadgets at all. Both are functional interfaces. I think that `Subscription` can replace it, but isn't critical. - PR Comment: https://git.openjdk.org/jfx/pull/1262#issuecomment-1768249992

Re: RFR: 8318204: Use new EventTarget methods in ListenerHelper

2023-10-17 Thread Andy Goryachev
On Tue, 17 Oct 2023 04:46:12 GMT, Michael Strauß wrote: > As of OpenJFX 21, `EventTarget` has methods to add and remove event listeners. > The `instanceof` checks in `com.sun.javafx.scene.control.ListenerHelper` > should be removed and replaced by a simple call to the respective interface > met

Re: RFR: 8318204: Use new EventTarget methods in ListenerHelper

2023-10-17 Thread Andy Goryachev
On Tue, 17 Oct 2023 11:04:03 GMT, Nir Lisker wrote: > By the way, isn't `IDisconnectable` just a `Subscription` with less gadgets? it's a functional interface, so no gadgets at all. - PR Comment: https://git.openjdk.org/jfx/pull/1262#issuecomment-1766533941

Re: RFR: 8318204: Use new EventTarget methods in ListenerHelper

2023-10-17 Thread Nir Lisker
On Tue, 17 Oct 2023 04:46:12 GMT, Michael Strauß wrote: > As of OpenJFX 21, `EventTarget` has methods to add and remove event listeners. > The `instanceof` checks in `com.sun.javafx.scene.control.ListenerHelper` > should be removed and replaced by a simple call to the respective interface > met

Re: RFR: 8318204: Use new EventTarget methods in ListenerHelper

2023-10-17 Thread John Hendrikx
On Tue, 17 Oct 2023 04:46:12 GMT, Michael Strauß wrote: > As of OpenJFX 21, `EventTarget` has methods to add and remove event listeners. > The `instanceof` checks in `com.sun.javafx.scene.control.ListenerHelper` > should be removed and replaced by a simple call to the respective interface > met