Re: RFR: 8317370: JavaFX runtime version is wrong at runtime [v2]

2023-10-14 Thread Joeri Sykora
On Tue, 10 Oct 2023 16:24:42 GMT, John Neffenger wrote: >> Please review these changes to the build timestamp and to the JavaFX runtime >> version available in the system properties. > > John Neffenger has updated the pull request incrementally with one additional > commit since the last revisi

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime [v2]

2023-10-12 Thread Florian Kirmaier
On Tue, 10 Oct 2023 16:24:42 GMT, John Neffenger wrote: >> Please review these changes to the build timestamp and to the JavaFX runtime >> version available in the system properties. > > John Neffenger has updated the pull request incrementally with one additional > commit since the last revisi

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime [v2]

2023-10-10 Thread Kevin Rushforth
On Tue, 10 Oct 2023 16:24:42 GMT, John Neffenger wrote: >> Please review these changes to the build timestamp and to the JavaFX runtime >> version available in the system properties. > > John Neffenger has updated the pull request incrementally with one additional > commit since the last revisi

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime [v2]

2023-10-10 Thread John Neffenger
> Please review these changes to the build timestamp and to the JavaFX runtime > version available in the system properties. John Neffenger has updated the pull request incrementally with one additional commit since the last revision: Update the documentation in UPDATING-VERSION.md -

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime

2023-10-10 Thread John Neffenger
On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger wrote: > Please review these changes to the build timestamp and to the JavaFX runtime > version available in the system properties. Thanks, Kevin. I'll fix that. To all reviewers: I added tests of the method [VersionInfo.setupSystemProperties][1

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime

2023-10-10 Thread Kevin Rushforth
On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger wrote: > Please review these changes to the build timestamp and to the JavaFX runtime > version available in the system properties. The fix and new test both look good. Testing is green. Can you also change the following in [`UPDATING-VERSION.md

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime

2023-10-10 Thread Johan Vos
On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger wrote: > Please review these changes to the build timestamp and to the JavaFX runtime > version available in the system properties. @tiainen can you review? - PR Comment: https://git.openjdk.org/jfx/pull/1253#issuecomment-1754743752

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime

2023-10-09 Thread Kevin Rushforth
On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger wrote: > Please review these changes to the build timestamp and to the JavaFX runtime > version available in the system properties. @arapte or @johanvos Can one of you also review this? - PR Comment: https://git.openjdk.org/jfx/pull/

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime

2023-10-07 Thread John Neffenger
On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger wrote: > Please review these changes to the build timestamp and to the JavaFX runtime > version available in the system properties. @FlorianKirmaier Florian, I would appreciate any comments you might have, too, or even a formal review if you have

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime

2023-10-04 Thread John Neffenger
On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger wrote: > Please review these changes to the build timestamp and to the JavaFX runtime > version available in the system properties. This pull request makes three changes: 1. The ISO 8601 extended format of the build date and time is now used only

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime

2023-10-04 Thread Kevin Rushforth
On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger wrote: > Please review these changes to the build timestamp and to the JavaFX runtime > version available in the system properties. I'll take a closer look, and also test this, when I can. This looks like the right approach to me. It should not c