On Wed, 26 Jun 2024 06:33:43 GMT, Markus Mack wrote:
>> This PR ensures the `tickMarksUpdated()` method (overriden with minor tick
>> mark layout code in subclasses) is called during `Chart` `Axis` layout when
>> needed.
>> Previously, it was only called when tick mark length or range was chang
On Wed, 26 Jun 2024 06:33:43 GMT, Markus Mack wrote:
>> This PR ensures the `tickMarksUpdated()` method (overriden with minor tick
>> mark layout code in subclasses) is called during `Chart` `Axis` layout when
>> needed.
>> Previously, it was only called when tick mark length or range was chang
On Wed, 26 Jun 2024 06:33:43 GMT, Markus Mack wrote:
>> This PR ensures the `tickMarksUpdated()` method (overriden with minor tick
>> mark layout code in subclasses) is called during `Chart` `Axis` layout when
>> needed.
>> Previously, it was only called when tick mark length or range was chang
> This PR ensures the `tickMarksUpdated()` method (overriden with minor tick
> mark layout code in subclasses) is called during `Chart` `Axis` layout when
> needed.
> Previously, it was only called when tick mark length or range was changed,
> which is not happening during axis animations, causi
On Tue, 25 Jun 2024 22:48:26 GMT, Marius Hanl wrote:
>> Markus Mack has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - cleanup imports
>> - add clarifying comment to test
>
> modules/javafx.controls/src/test/java/test/javafx/scene/chart/
On Tue, 25 Jun 2024 21:46:25 GMT, Markus Mack wrote:
>> This PR ensures the `tickMarksUpdated()` method (overriden with minor tick
>> mark layout code in subclasses) is called during `Chart` `Axis` layout when
>> needed.
>> Previously, it was only called when tick mark length or range was chang
On Tue, 25 Jun 2024 22:13:34 GMT, Markus Mack wrote:
>> but wait: this may not be a different issue. I see a slightly different
>> behavior relative to the master branch:
>>
>> - select bubble chart page in the monkey tester
>> - add series with duplicate category
>>
>> now I see the minor ti
On Tue, 25 Jun 2024 21:46:25 GMT, Markus Mack wrote:
>> This PR ensures the `tickMarksUpdated()` method (overriden with minor tick
>> mark layout code in subclasses) is called during `Chart` `Axis` layout when
>> needed.
>> Previously, it was only called when tick mark length or range was chang
On Tue, 25 Jun 2024 21:51:36 GMT, Andy Goryachev wrote:
>> I think we need to create that as it turned out it's not the same as the
>> minor tick problem fixed by this PR.
>
> but wait: this may not be a different issue. I see a slightly different
> behavior relative to the master branch:
>
>
On Tue, 25 Jun 2024 21:41:54 GMT, Markus Mack wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/chart/XYNumberLineChartsTest.java
>> line 156:
>>
>>> 154: NumberAxis yAxis = (NumberAxis)chart.getYAxis();
>>> 155:
>>> 156: List majorTickYValues =
>>> yAxis.getCh
On Tue, 25 Jun 2024 21:43:58 GMT, Andy Goryachev wrote:
>> yes, the BarChart issue (which I actually want to get fixed) will need
>> additional fixes in other classes. I could add those to this PR, but
>> probably it's best to handle them in another ticket+PR to keep this PR
>> affecting all `
On Tue, 25 Jun 2024 21:49:54 GMT, Markus Mack wrote:
>> a separate PR would be best. I am getting lost - do we have a ticket for
>> that issue already or do we need to create one?
>
> I think we need to create that as it turned out it's not the same as the
> minor tick problem fixed by this PR
On Tue, 25 Jun 2024 21:42:23 GMT, Markus Mack wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/chart/Axis.java line 753:
>>
>>> 751:
>>> 752: // call tick marks updated to inform subclasses that we
>>> have updated tick marks
>>> 753: tickMarksUpdated();
>>
> This PR ensures the `tickMarksUpdated()` method (overriden with minor tick
> mark layout code in subclasses) is called during `Chart` `Axis` layout when
> needed.
> Previously, it was only called when tick mark length or range was changed,
> which is not happening during axis animations, causi
On Tue, 25 Jun 2024 20:06:29 GMT, Andy Goryachev wrote:
>> Markus Mack has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - cleanup imports
>> - add clarifying comment to test
>
> modules/javafx.controls/src/main/java/javafx/scene/chart/Ax
On Tue, 25 Jun 2024 15:14:14 GMT, Markus Mack wrote:
> This PR ensures the `tickMarksUpdated()` method (overriden with minor tick
> mark layout code in subclasses) is called during `Chart` `Axis` layout when
> needed.
> Previously, it was only called when tick mark length or range was changed,
On Tue, 25 Jun 2024 15:14:14 GMT, Markus Mack wrote:
> This PR ensures the `tickMarksUpdated()` method (overriden with minor tick
> mark layout code in subclasses) is called during `Chart` `Axis` layout when
> needed.
> Previously, it was only called when tick mark length or range was changed,
17 matches
Mail list logo
