On Fri, 8 Sep 2023 18:37:43 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request i
On Fri, 8 Sep 2023 18:37:43 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request i
> In the Control hierarchy, all property accessor methods must be declared
> `final`.
>
> Added a test to check for missing `final` keyword and added the said keyword
> where required.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
On Fri, 8 Sep 2023 18:18:30 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> only public
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java
> line 99:
>
On Fri, 8 Sep 2023 18:32:18 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request i
On Fri, 8 Sep 2023 18:13:45 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> only public
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java
> line 103:
On Fri, 8 Sep 2023 15:01:34 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request i
On Tue, 22 Aug 2023 09:46:28 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> Looks good. Gave a couple of minor optional suggestions.
>
> As to the topic of class finding, I t
On Fri, 8 Sep 2023 15:01:34 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request i
> In the Control hierarchy, all property accessor methods must be declared
> `final`.
>
> Added a test to check for missing `final` keyword and added the said keyword
> where required.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
On Fri, 8 Sep 2023 13:02:31 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commi
On Thu, 7 Sep 2023 23:32:15 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request w
On Thu, 7 Sep 2023 22:42:57 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java
> l
> In the Control hierarchy, all property accessor methods must be declared
> `final`.
>
> Added a test to check for missing `final` keyword and added the said keyword
> where required.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The incrementa
On Tue, 22 Aug 2023 15:15:29 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java
>> line 172:
>>
>>> 170: @Test
>>> 171: public void testMissingFinalMethods() {
>>> 172: for (Class c: allControlClasses()) {
>>
On Tue, 22 Aug 2023 15:34:17 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request
On Tue, 22 Aug 2023 09:13:08 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java
> line
> In the Control hierarchy, all property accessor methods must be declared
> `final`.
>
> Added a test to check for missing `final` keyword and added the said keyword
> where required.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
On Tue, 22 Aug 2023 05:51:32 GMT, John Hendrikx wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java
> li
On Mon, 21 Aug 2023 23:11:49 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request
On Mon, 21 Aug 2023 23:11:49 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request
On Mon, 21 Aug 2023 22:16:12 GMT, Nir Lisker wrote:
>> Thank you for suggestions!
>>
>> Frankly, I don't see much value in rewriting of this method. A more
>> interesting problem is how to enumerate all descendants of the Control class
>> using the package name, in such a way that will relia
> In the Control hierarchy, all property accessor methods must be declared
> `final`.
>
> Added a test to check for missing `final` keyword and added the said keyword
> where required.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
On Mon, 21 Aug 2023 22:16:50 GMT, Andy Goryachev wrote:
>>> these classes (in javafx.scene.control.cell) are public and in the Control
>>> hierarchy, so are subject of the 'final' limitation.
>>
>> I'm confused. Which classes should appear in this list exactly (what are the
>> rules to determi
On Mon, 21 Aug 2023 22:14:28 GMT, Nir Lisker wrote:
> Which classes should appear in this list exactly
subclasses of javafx.scene.control.Control
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1213#discussion_r1300705312
On Mon, 21 Aug 2023 15:27:44 GMT, Andy Goryachev wrote:
> these classes (in javafx.scene.control.cell) are public and in the Control
> hierarchy, so are subject of the 'final' limitation.
I'm confused. Which classes should appear in this list exactly (what are the
rules to determine that)?
>
On Sun, 20 Aug 2023 06:16:06 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java
> line
> In the Control hierarchy, all property accessor methods must be declared
> `final`.
>
> Added a test to check for missing `final` keyword and added the said keyword
> where required.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The incrementa
On Sun, 20 Aug 2023 21:17:18 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java
> line
On Fri, 18 Aug 2023 22:17:15 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request
On Fri, 18 Aug 2023 22:53:42 GMT, Kevin Rushforth wrote:
> Um, "classpath"?
The problem I was referring to is how to enumerate all descendants of Control
in javafx.* hierarchy, and I don't have a good solution. So, no change in the
unit test is being planned, and all newly developed controls
On Fri, 18 Aug 2023 22:17:15 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request
On Fri, 18 Aug 2023 22:32:58 GMT, Kevin Rushforth wrote:
> And thanks for adding a test.
I feel the test can be improved by collecting the classes automatically, so as
to catch possible issues when new controls are added (it'll be a full classpath
scan though). While the scan should be limite
On Fri, 18 Aug 2023 22:17:15 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request
On Fri, 18 Aug 2023 22:17:15 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request
On Fri, 18 Aug 2023 22:04:11 GMT, John Hendrikx wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java
> li
> In the Control hierarchy, all property accessor methods must be declared
> `final`.
>
> Added a test to check for missing `final` keyword and added the said keyword
> where required.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
On Thu, 17 Aug 2023 23:07:14 GMT, Andy Goryachev wrote:
> In the Control hierarchy, all property accessor methods must be declared
> `final`.
>
> Added a test to check for missing `final` keyword and added the said keyword
> where required.
Marked as reviewed by jhendrikx (Committer).
module
38 matches
Mail list logo
