On Thu, 12 Jun 2025 20:25:05 GMT, Kevin Rushforth wrote:
> I hope there aren't other places that make this same assumption.
I had the same thought. So far nothing I did resulted in an exception.
-
PR Comment: https://git.openjdk.org/jfx/pull/1605#issuecomment-2968070641
On Thu, 12 Jun 2025 19:41:47 GMT, Michael Strauß wrote:
> it was introduced by the previous patch. In order for CSS to work as
> expected, all nodes must be traceable to a single root node. This means that
> the parent of the overlay node is the scene root. However, in some cases
> during boun
On Thu, 12 Jun 2025 16:05:56 GMT, Andy Goryachev wrote:
> > On Windows, when switching to fullscreen mode, the application crashes with
> > an endless repetition of the error.
>
> Same issue on macOS 15.5
>
> Can be reproduced with the Stage Tester + simple HeaderBar. Perhaps it was
> introdu
On Thu, 12 Jun 2025 16:35:03 GMT, Kevin Rushforth wrote:
> > Somewhat related question: when the Stage is not resizable, why is it being
> > resized when going full screen?
>
> Not really related. Short answer: fullScreen overrides resizable.
On mac the fullscreen button is removed when it's n
On Thu, 12 Jun 2025 16:35:03 GMT, Kevin Rushforth wrote:
> fullScreen overrides resizable
I can't find where it is documented. Perhaps it should be added to both
`resizableProperty` and `fullScreenProperty` ?
-
PR Comment: https://git.openjdk.org/jfx/pull/1605#issuecomment-296755
On Tue, 10 Jun 2025 02:51:34 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> onl
On Thu, 12 Jun 2025 16:17:56 GMT, Andy Goryachev wrote:
> Somewhat related question: when the Stage is not resizable, why is it being
> resized when going full screen?
Not really related. Short answer: fullScreen overrides resizable.
-
PR Comment: https://git.openjdk.org/jfx/pull/
On Tue, 10 Jun 2025 02:51:34 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> onl
On Thu, 12 Jun 2025 10:57:54 GMT, Sergei wrote:
> On Windows, when switching to fullscreen mode, the application crashes with
> an endless repetition of the error.
Same issue on macOS 15.5
-
PR Comment: https://git.openjdk.org/jfx/pull/1605#issuecomment-2967427450
On Tue, 10 Jun 2025 02:51:34 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> onl
On Tue, 10 Jun 2025 02:51:34 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> onl
On Tue, 10 Jun 2025 17:38:16 GMT, Michael Strauß wrote:
> > > ```java
> > > .-FX-INTERNAL-header-button-container
> > > ```
> >
> >
> > yikes! I think I tried to modify this particular selector...
> > So let me ask this question again. Since the application can change these
> > styles, I feel
On Tue, 10 Jun 2025 02:51:34 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> onl
On Tue, 10 Jun 2025 02:51:34 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> onl
On Tue, 10 Jun 2025 17:30:44 GMT, Andy Goryachev wrote:
> > ```java
> > .-FX-INTERNAL-header-button-container
> > ```
>
> yikes! I think I tried to modify this particular selector...
>
> So let me ask this question again. Since the application can change these
> styles, I feel they should be d
On Tue, 10 Jun 2025 16:51:35 GMT, Andy Goryachev wrote:
> Looks good.
>
> Spent some time trying to set the new -FX-INTERNAL- CSS properties via scene
> stylesheet, failed as expected (win11). BTW, did not see any CSS errors in
> stderr.
This "works" for me:
scene.getStylesheets().add("data:
On Tue, 10 Jun 2025 02:51:34 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> onl
On Tue, 10 Jun 2025 02:51:34 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> onl
On Tue, 10 Jun 2025 02:51:34 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> onl
On Tue, 10 Jun 2025 03:21:53 GMT, Michael Strauß wrote:
> As it turns out, the CSS engine _really_ wants all styleable nodes to be
> traceable to a single root node. If that's not the case (as in this PR with
> the overlay buttons), all kinds of things go wrong.
>
> I've fixed this issue by ha
On Tue, 10 Jun 2025 02:51:34 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> onl
> Implementation of
> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
only dispose ViewSceneOverlay when non-null
-
Changes:
-
22 matches
Mail list logo
