On Thu, 27 Jul 2023 03:39:06 GMT, Nir Lisker wrote:
> A simple fix of changing the attenuation toggle from 1 to 0 for removed
> lights.
Marked as reviewed by kcr (Lead).
-
PR Review: https://git.openjdk.org/jfx/pull/1186#pullrequestreview-1551015235
On Thu, 27 Jul 2023 22:07:40 GMT, Kevin Rushforth wrote:
> > By the way, the lighting in the LightingSample test application looks a bit
> > off to me (regardless of this patch). It's as if the point and spot lights
> > are too dim even at close range. Do you also notice that? Might need to
>
On Thu, 27 Jul 2023 03:44:56 GMT, Nir Lisker wrote:
> @kevinrushforth I think that this is simple enough to be able to get into
> RDP1. There is some performance improvement regained here that was lost in
> one of my previous enhancements because of my mistake of setting this
> parameter to 1.
On Thu, 27 Jul 2023 03:39:06 GMT, Nir Lisker wrote:
> A simple fix of changing the attenuation toggle from 1 to 0 for removed
> lights.
@kevinrushforth I think that this is simple enough to be able to get into RDP1.
There is some performance improvement regained here that was lost in one of my
