Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v6]

2024-02-06 Thread Karthik P K
On Tue, 6 Feb 2024 13:49:13 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > minor cleanup to simplify test and fixed impo

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v6]

2024-02-06 Thread Ambarish Rapte
On Tue, 6 Feb 2024 13:49:13 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > minor cleanup to simplify test and fixed impo

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v6]

2024-02-06 Thread Laurent Bourgès
> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: minor cleanup to simplify test and fixed imports - Changes: - all: https://git.openjdk.org/jfx/pu

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v2]

2024-02-06 Thread Karthik P K
On Mon, 29 Jan 2024 09:09:40 GMT, Karthik P K wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed test package > > modules/javafx.graphics/src/main/java/com/sun/marlin/ArrayCacheDouble.java > line 168: > >>

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v5]

2024-02-06 Thread Ambarish Rapte
On Tue, 6 Feb 2024 00:06:58 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > improved rendez-vous to collect stderr Provi

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v5]

2024-02-05 Thread Laurent Bourgès
> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: improved rendez-vous to collect stderr - Changes: - all: https://git.openjdk.org/jfx/pull/1348/fi

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v4]

2024-02-04 Thread Ambarish Rapte
On Fri, 2 Feb 2024 13:14:26 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed tests thanks to + copyright years test

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v4]

2024-02-02 Thread Laurent Bourgès
> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: fixed tests thanks to + copyright years - Changes: - all: https://git.openjdk.org/jfx/pull/1348/f

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-02-01 Thread Ambarish Rapte
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed copyright years of modified files + fi

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v2]

2024-02-01 Thread Ambarish Rapte
On Mon, 29 Jan 2024 09:44:04 GMT, Karthik P K wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed test package > > modules/javafx.graphics/src/main/java/com/sun/marlin/DPathConsumer2D.java > line 2: > >> 1:

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-02-01 Thread Ambarish Rapte
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed copyright years of modified files + fi

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-31 Thread Laurent Bourgès
On Wed, 31 Jan 2024 18:40:29 GMT, Kevin Rushforth wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed copyright years of modified files + fixed comments in >> DMarlinPrismUtils > > I don't have any concerns.

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-31 Thread Kevin Rushforth
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed copyright years of modified files + fi

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-31 Thread Laurent Bourgès
On Tue, 30 Jan 2024 12:52:09 GMT, Kevin Rushforth wrote: >> Tests in BidirectionalBindingTest with following exception. (Note: This was >> during the first JavaFX pre-submit test for this PR) >> >> BidirectionalBindingTest > [0] > testDoubleBrokenBind[0] STANDARD_ERROR >> Exception in threa

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-31 Thread Karthik P K
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed copyright years of modified files + fi

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-30 Thread Karthik P K
On Tue, 30 Jan 2024 09:27:32 GMT, Karthik P K wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed copyright years of modified files + fixed comments in >> DMarlinPrismUtils > > Tests in BidirectionalBindingTe

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-30 Thread Kevin Rushforth
On Tue, 30 Jan 2024 09:27:32 GMT, Karthik P K wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed copyright years of modified files + fixed comments in >> DMarlinPrismUtils > > Tests in BidirectionalBindingTe

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-30 Thread Karthik P K
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed copyright years of modified files + fi

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-30 Thread Laurent Bourgès
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed copyright years of modified files + fi

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-30 Thread Karthik P K
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed copyright years of modified files + fi

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-29 Thread Laurent Bourgès
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed copyright years of modified files + fi

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-29 Thread Laurent Bourgès
> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: fixed copyright years of modified files + fixed comments in DMarlinPrismUtils - Changes: - all: h

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v2]

2024-01-29 Thread Kevin Rushforth
On Thu, 25 Jan 2024 17:16:51 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed test package Our headful CI test run

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v2]

2024-01-29 Thread Kevin Rushforth
On Fri, 26 Jan 2024 06:49:42 GMT, Laurent Bourgès wrote: > I fixed new test so system test run properly. How do you compare test runs in > CI ? GHA jobs only run headless tests. In order to do run system test we need physical test systems. We have the ability to run them internally (in our lab

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v2]

2024-01-29 Thread Karthik P K
On Thu, 25 Jan 2024 17:16:51 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed test package Tested the changes and i

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v2]

2024-01-25 Thread Laurent Bourgès
On Thu, 25 Jan 2024 17:16:51 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed test package I fixed new test so syst

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v2]

2024-01-25 Thread Laurent Bourgès
> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: fixed test package - Changes: - all: https://git.openjdk.org/jfx/pull/1348/files - new: https:/

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0

2024-01-24 Thread Karthik P K
On Wed, 24 Jan 2024 14:55:21 GMT, Laurent Bourgès wrote: > Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java @bourgesl Some of the unit tests looks to be failing. Can you please check? - PR Comment: https://git.openjdk.org/jfx/pull/1348#issuecomment-1908749026

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 + minor syntax fixes (merge with latest MarlinFX)

2024-01-24 Thread Kevin Rushforth
On Wed, 24 Jan 2024 14:55:21 GMT, Laurent Bourgès wrote: > Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java @bourgesl You will need to change the title of this PR to match that of the JBS bug. You can add the additional information by using the `/summary` command if you like