Re: RFR: 8311806: Class ButtonAccessibility is implemented twice

2023-07-17 Thread Ambarish Rapte
On Mon, 10 Jul 2023 20:39:34 GMT, Alexander Zuev wrote: > To avoid confusion on the os x dynamic linker side i renamed native classes > from ButtonAccessibility to JFXButtonAccessibility. I will use JFX prefix > down the line to avoid any confusion when running with the latest JDK that > also

Re: RFR: 8311806: Class ButtonAccessibility is implemented twice

2023-07-14 Thread Kevin Rushforth
On Fri, 14 Jul 2023 19:59:26 GMT, Alexander Zuev wrote: > The slight issue with this approach is that in my opinion the class names > will be too similar for the first look which will make code less readable. > Also that will make code in JDK and JFX less similar which might be a problem > for

Re: RFR: 8311806: Class ButtonAccessibility is implemented twice

2023-07-14 Thread Kevin Rushforth
On Mon, 10 Jul 2023 20:39:34 GMT, Alexander Zuev wrote: > To avoid confusion on the os x dynamic linker side i renamed native classes > from ButtonAccessibility to JFXButtonAccessibility. I will use JFX prefix > down the line to avoid any confusion when running with the latest JDK that > also

Re: RFR: 8311806: Class ButtonAccessibility is implemented twice

2023-07-14 Thread Alexander Zuev
On Thu, 13 Jul 2023 05:25:45 GMT, Ambarish Rapte wrote: > May I suggest an alternate naming pattern similar to AccessibleBase.h. Can we > name our files as AccessibleButton, (AccessibleList, ... and so forth) ? The slight issue with this approach is that in my opinion the class names will be t

Re: RFR: 8311806: Class ButtonAccessibility is implemented twice

2023-07-12 Thread Ambarish Rapte
On Mon, 10 Jul 2023 20:39:34 GMT, Alexander Zuev wrote: > To avoid confusion on the os x dynamic linker side i renamed native classes > from ButtonAccessibility to JFXButtonAccessibility. I will use JFX prefix > down the line to avoid any confusion when running with the latest JDK that > also

Re: RFR: 8311806: Class ButtonAccessibility is implemented twice

2023-07-12 Thread Alexander Zuev
On Tue, 11 Jul 2023 20:12:44 GMT, Kevin Rushforth wrote: > Is there a way to hide the symbols so that they are not exported? I do not think we can hide these symbols from the library - they have to be public for us to instantiate them dynamically based on the accessibility role of the FX node.

Re: RFR: 8311806: Class ButtonAccessibility is implemented twice

2023-07-11 Thread Kevin Rushforth
On Mon, 10 Jul 2023 20:39:34 GMT, Alexander Zuev wrote: > To avoid confusion on the os x dynamic linker side i renamed native classes > from ButtonAccessibility to JFXButtonAccessibility. I will use JFX prefix > down the line to avoid any confusion when running with the latest JDK that > also