Re: RFR: 8311216: DataURI can lose information in some charset environments [v3]

2023-10-28 Thread Michael Strauß
On Sat, 28 Oct 2023 19:59:38 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review changes > > modules/javafx.graphics/src/main/java/com/sun/javafx/util/DataURI.java line > 211: > >> 209:

Re: RFR: 8311216: DataURI can lose information in some charset environments [v3]

2023-10-28 Thread John Hendrikx
On Sat, 28 Oct 2023 18:11:08 GMT, Michael Strauß wrote: >> DataURI uses the following implementation to decode the percent-encoded >> payload of a "data" URI: >> >> >> ... >> String data = uri.substring(dataSeparator + 1); >> Charset charset = Charset.defaultCharset(); >> ... >> URLDecoder.dec

Re: RFR: 8311216: DataURI can lose information in some charset environments [v3]

2023-10-28 Thread Michael Strauß
> DataURI uses the following implementation to decode the percent-encoded > payload of a "data" URI: > > > ... > String data = uri.substring(dataSeparator + 1); > Charset charset = Charset.defaultCharset(); > ... > URLDecoder.decode(data.replace("+", "%2B"), charset).getBytes(charset) > > > Th