On Fri, 16 Jun 2023 15:35:42 GMT, Andy Goryachev wrote:
>> A recent change in JDK-8304831 ensured that insertionIndex is always
>> computed prior to HitInfo construction, making it possible to remove buggy
>> logic in HitInfo. This change also allows for removal of the 'text' field.
>>
>> Th
On Fri, 16 Jun 2023 15:35:42 GMT, Andy Goryachev wrote:
>> A recent change in JDK-8304831 ensured that insertionIndex is always
>> computed prior to HitInfo construction, making it possible to remove buggy
>> logic in HitInfo. This change also allows for removal of the 'text' field.
>>
>> Th
On Fri, 16 Jun 2023 15:35:17 GMT, Andy Goryachev wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/TextSurrogatePairInsertionIndexTest.java
>> line 100:
>>
>>> 98: public static void initFX() {
>>> 99: long seed = new Random().nextLong();
>>> 100: System.out.print
On Fri, 16 Jun 2023 08:34:29 GMT, Karthik P K wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> tests/system/src/test/java/test/robot/javafx/scene/TextSurrogatePairInsertionIndexTest.java
> lin
> A recent change in JDK-8304831 ensured that insertionIndex is always computed
> prior to HitInfo construction, making it possible to remove buggy logic in
> HitInfo. This change also allows for removal of the 'text' field.
>
> There should be no impact since the constructor is package protec
On Thu, 15 Jun 2023 18:38:14 GMT, Andy Goryachev wrote:
>> A recent change in JDK-8304831 ensured that insertionIndex is always
>> computed prior to HitInfo construction, making it possible to remove buggy
>> logic in HitInfo. This change also allows for removal of the 'text' field.
>>
>> Th
On Thu, 15 Jun 2023 14:42:43 GMT, Karthik P K wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> The fix looks good to me.
> Can we add a test to verify the changes?
> Another minor comment: copy
> A recent change in JDK-8304831 ensured that insertionIndex is always computed
> prior to HitInfo construction, making it possible to remove buggy logic in
> HitInfo. This change also allows for removal of the 'text' field.
>
> There should be no impact since the constructor is package protec
On Wed, 14 Jun 2023 15:40:41 GMT, Andy Goryachev wrote:
> A recent change in JDK-8304831 ensured that insertionIndex is always computed
> prior to HitInfo construction, making it possible to remove buggy logic in
> HitInfo. This change also allows for removal of the 'text' field.
>
> There s
On Wed, 14 Jun 2023 15:40:41 GMT, Andy Goryachev wrote:
> A recent change in JDK-8304831 ensured that insertionIndex is always computed
> prior to HitInfo construction, making it possible to remove buggy logic in
> HitInfo. This change also allows for removal of the 'text' field.
>
> There s
On Wed, 14 Jun 2023 15:40:41 GMT, Andy Goryachev wrote:
> A recent change in JDK-8304831 ensured that insertionIndex is always computed
> prior to HitInfo construction, making it possible to remove buggy logic in
> HitInfo. This change also allows for removal of the 'text' field.
>
> There s
11 matches
Mail list logo
