Re: RFR: 8302472 WebColorFieldSkin should use precompiled Pattern

2023-02-22 Thread Kevin Rushforth
On Tue, 14 Feb 2023 16:12:29 GMT, John Hendrikx wrote: > Split off from https://github.com/openjdk/jfx/pull/837 > > This uses a precompiled regex pattern and cleans up the code in > WebColorFieldSkin a bit. @hjohn you can integrate this when you are ready. - PR: https://git.openj

Re: RFR: 8302472 WebColorFieldSkin should use precompiled Pattern

2023-02-17 Thread Ajit Ghaisas
On Tue, 14 Feb 2023 16:12:29 GMT, John Hendrikx wrote: > Split off from https://github.com/openjdk/jfx/pull/837 > > This uses a precompiled regex pattern and cleans up the code in > WebColorFieldSkin a bit. This looks good! - Marked as reviewed by aghaisas (Reviewer). PR: https:

Re: RFR: 8302472 WebColorFieldSkin should use precompiled Pattern

2023-02-16 Thread Michael Strauß
On Tue, 14 Feb 2023 16:12:29 GMT, John Hendrikx wrote: > Split off from https://github.com/openjdk/jfx/pull/837 > > This uses a precompiled regex pattern and cleans up the code in > WebColorFieldSkin a bit. modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/WebColorFieldSk