Re: RFR: 8301761: The sorting of the SortedList can become invalid [v4]

2024-10-16 Thread Nir Lisker
On Mon, 7 Oct 2024 16:25:22 GMT, Loay Ghreeb wrote: >> Fix an issue in `SortedList` where the sorting became incorrect when adding >> new items that are equal to existing items according to the comparator. The >> `SortedList` should consider the insertion index of these items to maintain >> th

Re: RFR: 8301761: The sorting of the SortedList can become invalid [v4]

2024-10-12 Thread Oliver Kopp
On Mon, 7 Oct 2024 16:25:22 GMT, Loay Ghreeb wrote: >> Fix an issue in `SortedList` where the sorting became incorrect when adding >> new items that are equal to existing items according to the comparator. The >> `SortedList` should consider the insertion index of these items to maintain >> th

Re: RFR: 8301761: The sorting of the SortedList can become invalid [v2]

2024-10-08 Thread Kevin Rushforth
On Sat, 10 Aug 2024 07:10:03 GMT, Loay Ghreeb wrote: >> The PR title "The sorting of the SortedList can become invalid" seems to >> imply that the sorting can become incorrect, as in the incorrect order. >> >> This is not the case. The sorting is still correct. Claiming that the >> sorting is

Re: RFR: 8301761: The sorting of the SortedList can become invalid [v4]

2024-10-07 Thread Loay Ghreeb
> Fix an issue in `SortedList` where the sorting became incorrect when adding > new items that are equal to existing items according to the comparator. The > `SortedList` should consider the insertion index of these items to maintain > the correct order. Loay Ghreeb has updated the pull request

Re: RFR: 8301761: The sorting of the SortedList can become invalid [v3]

2024-09-05 Thread Loay Ghreeb
> Fix an issue in `SortedList` where the sorting became incorrect when adding > new items that are equal to existing items according to the comparator. The > `SortedList` should consider the insertion index of these items to maintain > the correct order. Loay Ghreeb has updated the pull request

Re: RFR: 8301761: The sorting of the SortedList can become invalid [v2]

2024-08-12 Thread Nir Lisker
On Sat, 10 Aug 2024 11:53:00 GMT, John Hendrikx wrote: >>> This is not the case. The sorting is still correct. Claiming that the >>> sorting is invalid because a newly added item was not placed in a specific >>> location relative to other equal items is a bit of misrepresentation. >>> >>> So,

Re: RFR: 8301761: The sorting of the SortedList can become invalid [v2]

2024-08-10 Thread John Hendrikx
On Sat, 10 Aug 2024 07:10:03 GMT, Loay Ghreeb wrote: > Shift + Click again on Col2 to remove the sort from Col2. The order will stay > the same [1, 0, 3, 2], but the expected order is [1, 0, 2, 3] as in step 2. Why is that the expected order? It is "a" possible, but valid order. When only so

Re: RFR: 8301761: The sorting of the SortedList can become invalid [v2]

2024-08-10 Thread Loay Ghreeb
On Fri, 9 Aug 2024 19:11:24 GMT, John Hendrikx wrote: > This is not the case. The sorting is still correct. Claiming that the sorting > is invalid because a newly added item was not placed in a specific location > relative to other equal items is a bit of misrepresentation. > > So, if this PR

Re: RFR: 8301761: The sorting of the SortedList can become invalid [v2]

2024-08-09 Thread John Hendrikx
On Fri, 9 Aug 2024 03:30:09 GMT, Loay Ghreeb wrote: >> Fix an issue in `SortedList` where the sorting became incorrect when adding >> new items that are equal to existing items according to the comparator. The >> `SortedList` should consider the insertion index of these items to maintain >> th

Re: RFR: 8301761: The sorting of the SortedList can become invalid [v2]

2024-08-08 Thread Loay Ghreeb
> Fix an issue in `SortedList` where the sorting became incorrect when adding > new items that are equal to existing items according to the comparator. The > `SortedList` should consider the insertion index of these items to maintain > the correct order. Loay Ghreeb has updated the pull request

Re: RFR: 8301761: The sorting of the SortedList can become invalid

2024-08-08 Thread Loay Ghreeb
On Sun, 28 Jul 2024 04:13:30 GMT, Loay Ghreeb wrote: > Fix an issue in `SortedList` where the sorting became incorrect when adding > new items that are equal to existing items according to the comparator. The > `SortedList` should consider the insertion index of these items to maintain > the c