Re: RFR: 8301312: Create implementation of NSAccessibilityButton protocol [v4]

2023-05-31 Thread Alexander Zuev
On Mon, 22 May 2023 22:43:32 GMT, Kevin Rushforth wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Properly use NSObject instead of the GlassAccessible type. > > modules/javafx.graphics/src/main/native-glass/mac/a

Re: RFR: 8301312: Create implementation of NSAccessibilityButton protocol [v4]

2023-05-24 Thread Alexander Zuev
On Mon, 22 May 2023 22:38:15 GMT, Kevin Rushforth wrote: > Why was this method moved from GlassAccessible.m to here? It seems fine, I > was just curious. Eventually all the functionality will be moved from the GlassAccessible to the new classes. In this case i moved the method because i change

Re: RFR: 8301312: Create implementation of NSAccessibilityButton protocol [v4]

2023-05-23 Thread Kevin Rushforth
On Mon, 22 May 2023 23:25:01 GMT, Kevin Rushforth wrote: > I did get a one-time exception while playing around with Ensemble8, I can't > reproduce it. It was in the existing code, so it might be unrelated to your > change. Definitely unrelated to your change. When doing some side-by-side testi

Re: RFR: 8301312: Create implementation of NSAccessibilityButton protocol [v4]

2023-05-22 Thread Kevin Rushforth
On Wed, 17 May 2023 20:31:27 GMT, Alexander Zuev wrote: >> Add the common base component for all the new implementing native classes >> Change native peer creation to use the new base component The new code will >> instantiate new protocol implementation for the given role if it exists or >>

Re: RFR: 8301312: Create implementation of NSAccessibilityButton protocol [v4]

2023-05-17 Thread Alexander Zuev
On Sat, 8 Apr 2023 14:36:30 GMT, Kevin Rushforth wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Properly use NSObject instead of the GlassAccessible type. > > modules/javafx.graphics/src/main/native-glass/mac/a1

Re: RFR: 8301312: Create implementation of NSAccessibilityButton protocol [v4]

2023-05-17 Thread Alexander Zuev
> Add the common base component for all the new implementing native classes > Change native peer creation to use the new base component The new code will > instantiate new protocol implementation for the given role if it exists or > an old one if it does not exist > Added BUTTON role implementi