Re: RFR: 8283675: Line not removed from LineChart when series cleared

2023-09-01 Thread Ajit Ghaisas
On Fri, 18 Aug 2023 07:25:28 GMT, Karthik P K wrote: > The issue is present in AreaChart along with the LineChart. Issue is fixed in > both the charts as part of this PR. > The line elements in case of Line chart and both line element and fill > element in the case of Area charts were not clear

Re: RFR: 8283675: Line not removed from LineChart when series cleared

2023-08-22 Thread Karthik P K
On Tue, 22 Aug 2023 14:52:50 GMT, Andy Goryachev wrote: >> Could be useful. Do you think it should be done as part of this PR or should >> we create separate bug and take it up in test sprint? > > sure, we can use the upcoming test sprint to add these tests. would you > please create a ticket?

Re: RFR: 8283675: Line not removed from LineChart when series cleared

2023-08-22 Thread Andy Goryachev
On Tue, 22 Aug 2023 09:37:46 GMT, Karthik P K wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/chart/AreaChartTest.java >> line 502: >> >>> 500: >>> 501: //JDK-8283675 >>> 502: @Test public void testChartFillRemovedOnClearingSeries() { >> >> should we add a similar te

Re: RFR: 8283675: Line not removed from LineChart when series cleared

2023-08-22 Thread Andy Goryachev
On Fri, 18 Aug 2023 07:25:28 GMT, Karthik P K wrote: > The issue is present in AreaChart along with the LineChart. Issue is fixed in > both the charts as part of this PR. > The line elements in case of Line chart and both line element and fill > element in the case of Area charts were not clear

Re: RFR: 8283675: Line not removed from LineChart when series cleared

2023-08-22 Thread Karthik P K
On Mon, 21 Aug 2023 18:41:01 GMT, Andy Goryachev wrote: > @karthikpandelu would you please check if we already have a similar issue and > create one if not? I couldn't find a similar issue, created [JDK-8314754](https://bugs.openjdk.org/browse/JDK-8314754) > modules/javafx.controls/src/test/j

Re: RFR: 8283675: Line not removed from LineChart when series cleared

2023-08-21 Thread Andy Goryachev
On Fri, 18 Aug 2023 07:25:28 GMT, Karthik P K wrote: > The issue is present in AreaChart along with the LineChart. Issue is fixed in > both the charts as part of this PR. > The line elements in case of Line chart and both line element and fill > element in the case of Area charts were not clear