Re: RFR: 8267546: Add CSS themes as a first-class concept [v21]

2023-01-21 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept [v20]

2023-01-21 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept [v19]

2023-01-21 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept [v18]

2023-01-13 Thread Pedro Duque Vieira
On Mon, 9 Jan 2023 18:33:40 GMT, Michael Strauß wrote: >> This PR adds style themes as a first-class concept to OpenJFX. A style theme >> is a collection of stylesheets and the logic that governs them. Style themes >> can respond to OS notifications and update their stylesheets dynamically. >>

Re: RFR: 8267546: Add CSS themes as a first-class concept [v2]

2023-01-10 Thread Michael Strauß
On Fri, 11 Nov 2022 01:11:36 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/javafx/application/PlatformPreferences.java >> line 117: >> >>> 115: * @since 20 >>> 116: */ >>> 117: public interface PlatformPreferences extends Map { >> >> Are you sure it is a good idea to ex

Re: RFR: 8267546: Add CSS themes as a first-class concept [v18]

2023-01-09 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept [v17]

2023-01-03 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept [v16]

2023-01-03 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept [v15]

2022-12-31 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept [v14]

2022-12-25 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept [v13]

2022-12-22 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept [v12]

2022-12-22 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept [v11]

2022-12-22 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept [v10]

2022-12-20 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept [v9]

2022-12-20 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept [v8]

2022-12-12 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept [v7]

2022-12-12 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept [v6]

2022-11-23 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept [v5]

2022-11-22 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept [v4]

2022-11-21 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept

2022-11-19 Thread Michael Strauß
On Wed, 9 Nov 2022 22:58:56 GMT, Kevin Rushforth wrote: > This will take a fair bit of discussion regarding how various applications > might use such a feature, what the API should look like, etc. > I think there are basically three categories of how applications might use this feature: 1. Ex

Re: RFR: 8267546: Add CSS themes as a first-class concept [v2]

2022-11-10 Thread Michael Strauß
On Thu, 10 Nov 2022 23:31:36 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update PlatformPreferences when dark mode is enabled > > modules/javafx.graphics/src/main/java/javafx/application/Pl

Re: RFR: 8267546: Add CSS themes as a first-class concept [v3]

2022-11-10 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept [v2]

2022-11-10 Thread Michael Strauß
On Thu, 10 Nov 2022 23:04:41 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update PlatformPreferences when dark mode is enabled > > modules/javafx.controls/src/main/java/javafx/scene/control/

Re: RFR: 8267546: Add CSS themes as a first-class concept [v2]

2022-11-10 Thread John Hendrikx
On Thu, 10 Nov 2022 20:29:18 GMT, Michael Strauß wrote: >> This PR adds style themes as a first-class concept to OpenJFX. A style theme >> is a collection of stylesheets and the logic that governs them. Style themes >> can respond to OS notifications and update their stylesheets dynamically. >

Re: RFR: 8267546: Add CSS themes as a first-class concept [v2]

2022-11-10 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: RFR: 8267546: Add CSS themes as a first-class concept

2022-11-09 Thread Jose Pereda
On Wed, 26 May 2021 17:34:14 GMT, Michael Strauß wrote: >> Oh, too bad, but thanks for testing anyway. >> Do you know if there is such API that returns a non-localized string? I read >> it somewhere... > > I don't know of such an API. Even when I change the locale of the current > thread to Eng

Re: RFR: 8267546: Add CSS themes as a first-class concept

2022-11-09 Thread Kevin Rushforth
On Fri, 21 May 2021 04:30:28 GMT, Michael Strauß wrote: > This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > Th

Re: RFR: 8267546: Add CSS themes as a first-class concept

2022-11-09 Thread Michael Strauß
On Wed, 26 May 2021 17:40:19 GMT, Jose Pereda wrote: >> I don't know of such an API. Even when I change the locale of the current >> thread to English, the API returns the localized (non-English) name of the >> scheme. > > Yes, I know, I've got a possible fix for JDK-8185447 based precisely in

Re: RFR: 8267546: Add CSS themes as a first-class concept

2022-11-09 Thread Michael Strauß
On Wed, 26 May 2021 17:23:36 GMT, Jose Pereda wrote: >> I just checked on Windows 10 v20H2 (build 19042.985), and unfortunately the >> `Windows.UI.ViewManagement.AccessibleSettings.HighContrastScheme` contains a >> localized name for the high contrast scheme. > > Oh, too bad, but thanks for tes

Re: RFR: 8267546: Add CSS themes as a first-class concept

2022-11-09 Thread Michael Strauß
On Fri, 21 May 2021 04:30:28 GMT, Michael Strauß wrote: > This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > Th

Re: RFR: 8267546: Add CSS themes as a first-class concept

2022-11-09 Thread Michael Strauß
On Fri, 21 May 2021 04:30:28 GMT, Michael Strauß wrote: > This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > Th

Re: RFR: 8267546: Add CSS themes as a first-class concept

2022-11-09 Thread Michael Strauß
On Wed, 26 May 2021 16:55:04 GMT, Jose Pereda wrote: >> This PR adds style themes as a first-class concept to OpenJFX. A style theme >> is a collection of stylesheets and the logic that governs them. Style themes >> can respond to OS notifications and update their stylesheets dynamically. >> T

Re: RFR: 8267546: Add CSS themes as a first-class concept

2022-11-09 Thread Jose Pereda
On Fri, 21 May 2021 04:30:28 GMT, Michael Strauß wrote: > This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > Th

Re: RFR: 8267546: Add CSS themes as a first-class concept

2022-11-09 Thread Michael Strauß
On Thu, 1 Jul 2021 09:36:13 GMT, Mike Hearn wrote: >> This PR adds style themes as a first-class concept to OpenJFX. A style theme >> is a collection of stylesheets and the logic that governs them. Style themes >> can respond to OS notifications and update their stylesheets dynamically. >> Thi

Re: RFR: 8267546: Add CSS themes as a first-class concept

2022-11-09 Thread Jose Pereda
On Wed, 26 May 2021 17:45:21 GMT, Michael Strauß wrote: >> Yes, I know, I've got a possible fix for JDK-8185447 based precisely in >> using the localized high contrast scheme names (limited to the same >> languages supported in Controls). > > Just for reference: I've proposed [this > enhanceme

Re: RFR: 8267546: Add CSS themes as a first-class concept

2022-11-09 Thread Michael Strauß
On Wed, 26 May 2021 17:52:35 GMT, Jose Pereda wrote: >> Just for reference: I've proposed [this >> enhancement](https://bugs.openjdk.java.net/browse/JDK-8267554) to load >> dynamic stylesheets that could be injected with the actual scheme colors. If >> added, this might be a better fix than ma

Re: RFR: 8267546: Add CSS themes as a first-class concept

2022-11-09 Thread Mike Hearn
On Fri, 21 May 2021 04:30:28 GMT, Michael Strauß wrote: > This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > Th

Re: RFR: 8267546: Add CSS themes as a first-class concept

2022-11-09 Thread Jose Pereda
On Wed, 26 May 2021 17:07:39 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/native-glass/win/ThemeSupport.cpp line 44: >> >>> 42: } >>> 43: >>> 44: void ThemeSupport::queryHighContrastScheme(jobject properties) >> >> @mstr2 Do you think it is possible to use here >> `Windows.U

Re: RFR: 8267546: Add CSS themes as a first-class concept

2022-11-09 Thread airsquared
On Fri, 21 May 2021 04:30:28 GMT, Michael Strauß wrote: > This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > Th