On Wed, 25 Jan 2023 11:19:06 GMT, Ajit Ghaisas wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> The fix looks good to me!
@aghaisas please sponsor the PR.
-
PR: https://git.
On Mon, 23 Jan 2023 08:24:23 GMT, Karthik P K wrote:
>> No check was present in `RadioMenuItem` accelerator to see if it is in a
>> `ToggleGroup` or not.
>>
>> Made changes to check if `RadioMenuItem` is part of `ToggleGroup` or not. If
>> it is part of a `ToggleGroup`, then it can not be clea
On Mon, 23 Jan 2023 08:24:23 GMT, Karthik P K wrote:
>> No check was present in `RadioMenuItem` accelerator to see if it is in a
>> `ToggleGroup` or not.
>>
>> Made changes to check if `RadioMenuItem` is part of `ToggleGroup` or not. If
>> it is part of a `ToggleGroup`, then it can not be clea
> No check was present in `RadioMenuItem` accelerator to see if it is in a
> `ToggleGroup` or not.
>
> Made changes to check if `RadioMenuItem` is part of `ToggleGroup` or not. If
> it is part of a `ToggleGroup`, then it can not be cleared using accelerator.
>
> Added test to validate the chang
On Fri, 20 Jan 2023 19:13:36 GMT, Andy Goryachev wrote:
> Tested with the MonkeyTester app.
>
> I'd like to have a discussion on a new ToggleGroup's property (i'll send an
> email to the mailing list).
I saw the mail chain sent out for this discussion. I agree that if any changes
required as
On Sat, 21 Jan 2023 22:58:02 GMT, Michael Strauß wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ControlAcceleratorSupport.java
>> line 178:
>>
>>> 176: if (!menuitem.isDisable()) {
>>> 177: if (menuitem instanceof
On Fri, 20 Jan 2023 19:06:32 GMT, Andy Goryachev wrote:
>> No check was present in `RadioMenuItem` accelerator to see if it is in a
>> `ToggleGroup` or not.
>>
>> Made changes to check if `RadioMenuItem` is part of `ToggleGroup` or not. If
>> it is part of a `ToggleGroup`, then it can not be c
On Thu, 19 Jan 2023 12:54:55 GMT, Karthik P K wrote:
> No check was present in `RadioMenuItem` accelerator to see if it is in a
> `ToggleGroup` or not.
>
> Made changes to check if `RadioMenuItem` is part of `ToggleGroup` or not. If
> it is part of a `ToggleGroup`, then it can not be cleared u
