On Sat, 9 Nov 2024 00:49:22 GMT, Martin Fox wrote:
> > I checked the events that are copied, and it is basically making the copy
> > to adjust the source (target remains constant). That's really odd; I'd
> > expect the source to remain the same as well (ie. the Scene or Window, not
> > the "pr
On Sat, 9 Nov 2024 00:22:42 GMT, John Hendrikx wrote:
> I checked the events that are copied, and it is basically making the copy to
> adjust the source (target remains constant). That's really odd; I'd expect
> the source to remain the same as well (ie. the Scene or Window, not the
> "previou
On Fri, 8 Nov 2024 22:05:15 GMT, Martin Fox wrote:
> FWIW, checking the isConsumed flag will only work if the action is consumed
> by a handler registered directly with the TextField. If there's a filter or
> handler attached to some other part of the scene graph a copy of the event
> will be
On Fri, 8 Nov 2024 20:44:17 GMT, John Hendrikx wrote:
>> @kleopatra Your explanation makes sense to me. Thank you for taking the time
>> to write it up.
>>
>> If so, the proposed fix, including adjusting the comment, would be:
>>
>>
>> ---
>> a/modules/javafx.controls/src/main/java/com/sun/j
On Fri, 8 Nov 2024 16:28:17 GMT, Kevin Rushforth wrote:
>> @hjohn @kevinrushforth @aghaisas
>>
>> hmm .. it's been a while but you might be on to something.
>>
>> Let's recap:
>>
>> - the first issue to get fixed was JDK-8207774: the problem was that the
>> isConsumed always was false (due
On Fri, 8 Nov 2024 15:39:57 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextFieldBehavior.java
>> line 190:
>>
>>> 188: if (onAction != null || actionEvent.isConsumed()) {
>>> 189: event.consume();
>>> 190:
On Fri, 8 Nov 2024 15:31:04 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextFieldBehavior.java
>> line 190:
>>
>>> 188: if (onAction != null || actionEvent.isConsumed()) {
>>> 189: event.consume();
>>> 190:
On Fri, 8 Nov 2024 12:48:45 GMT, John Hendrikx wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added tests to guard against JDK-8145515
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/
On Wed, 11 Dec 2019 12:26:27 GMT, Jeanette Winzenburg
wrote:
>> This is a fix for https://bugs.openjdk.java.net/browse/JDK-8207759
>>
>> The issue is that default/cancel button on a scene are triggered even though
>> a onKeyPressed handler for ENTER/CANCEL consumes the keyEvent. See the bug
>
