Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v13]

2023-11-01 Thread Andy Goryachev
On Tue, 31 Oct 2023 21:55:20 GMT, Sai Pradeep Dandem wrote: >> **Issue:** >> Using pseudo classes in programmatic query using Node.lookupAll() or >> Node.lookup() gives unexpected results. >> >> **Cause:** >> There is no check for checking the psuedo states matching in the applies() >> method

Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v13]

2023-11-01 Thread Sai Pradeep Dandem
On Wed, 1 Nov 2023 16:10:09 GMT, Kevin Rushforth wrote: > @SaiPradeepDandem This is now OK to integrate. @kevinrushforth thanks for confirming. But I am pretty not sure what steps I need to do next. Is it that I need to type a new comment with /integrate ? as mentioned in `To flag this PR a

Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v13]

2023-11-01 Thread Kevin Rushforth
On Tue, 31 Oct 2023 21:55:20 GMT, Sai Pradeep Dandem wrote: >> **Issue:** >> Using pseudo classes in programmatic query using Node.lookupAll() or >> Node.lookup() gives unexpected results. >> >> **Cause:** >> There is no check for checking the psuedo states matching in the applies() >> method

Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v13]

2023-11-01 Thread Andy Goryachev
On Tue, 31 Oct 2023 21:55:20 GMT, Sai Pradeep Dandem wrote: >> **Issue:** >> Using pseudo classes in programmatic query using Node.lookupAll() or >> Node.lookup() gives unexpected results. >> >> **Cause:** >> There is no check for checking the psuedo states matching in the applies() >> method

Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v13]

2023-11-01 Thread John Hendrikx
On Tue, 31 Oct 2023 21:55:20 GMT, Sai Pradeep Dandem wrote: >> **Issue:** >> Using pseudo classes in programmatic query using Node.lookupAll() or >> Node.lookup() gives unexpected results. >> >> **Cause:** >> There is no check for checking the psuedo states matching in the applies() >> method

Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v13]

2023-11-01 Thread Kevin Rushforth
On Tue, 31 Oct 2023 21:55:20 GMT, Sai Pradeep Dandem wrote: >> **Issue:** >> Using pseudo classes in programmatic query using Node.lookupAll() or >> Node.lookup() gives unexpected results. >> >> **Cause:** >> There is no check for checking the psuedo states matching in the applies() >> method

Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v13]

2023-10-31 Thread Sai Pradeep Dandem
> **Issue:** > Using pseudo classes in programmatic query using Node.lookupAll() or > Node.lookup() gives unexpected results. > > **Cause:** > There is no check for checking the psuedo states matching in the applies() > method of SimpleSelector.java. So checking for "applies()" alone is not > s