On Tue, 29 Oct 2024 20:06:24 GMT, Andy Goryachev wrote:
> Getting back to the API, are you ok with dropping the boolean `visible`
> argument and documenting the expectation of the key event?
Yes, I think that's okay.
-
PR Comment: https://git.openjdk.org/jfx/pull/1604#issuecomment
On Tue, 29 Oct 2024 18:14:31 GMT, Michael Strauß wrote:
> Just to complete the picture, I also want to explain why I am strongly
> against making `focusVisible` writable.
I don't disagree, I'm just a bit on the fence if making it writable by proxy is
a good idea then when it is a concept that
On Tue, 29 Oct 2024 21:53:06 GMT, Nir Lisker wrote:
> In that case, you are right. I don't have a strong opinion as I am not an
> advanced user of focus. The current behavior is good enough for me.
>
> By the way, if you have multiple scenes in the stage, and each one has its
> own focused nod
On Tue, 29 Oct 2024 21:47:53 GMT, John Hendrikx wrote:
> > > Also something that just occurred to me, but perhaps I'm late to the
> > > party; with the current API being on `Node` you could call
> > > `requestFocusTraversal` on basically any `Node`, even one that is
> > > currently not focused
On Tue, 29 Oct 2024 21:31:59 GMT, John Hendrikx wrote:
> ps. the diff for this PR still looks huge here?
Mainly because of TraversalEngine -> TraversalPolicy refactoring and skins.
And yes, one can call requestFocusTraversal on any Node, focusable or not.
There was some language to that effec
On Tue, 29 Oct 2024 21:40:45 GMT, Nir Lisker wrote:
> > Also something that just occurred to me, but perhaps I'm late to the party;
> > with the current API being on `Node` you could call `requestFocusTraversal`
> > on basically any `Node`, even one that is currently not focused. I'm not
> > s
On Mon, 28 Oct 2024 19:20:28 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/
On Tue, 29 Oct 2024 21:31:59 GMT, John Hendrikx wrote:
> Also something that just occurred to me, but perhaps I'm late to the party;
> with the current API being on `Node` you could call `requestFocusTraversal`
> on basically any `Node`, even one that is currently not focused. I'm not sure
> i
On Mon, 28 Oct 2024 19:20:28 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/
On Tue, 29 Oct 2024 19:33:20 GMT, Andy Goryachev wrote:
> It's one of the falsehoods programmers should be aware of.
>
> But regardless of how they interact with the UI, the focus indicator should
> always indicate the focus owner, no? There might be levels of indication,
> such as grayed focu
On Tue, 29 Oct 2024 17:55:55 GMT, Michael Strauß wrote:
> users of a GUI will interact with a mouse (or touch), not with the keyboard.
It's one of the falsehoods programmers should be aware of.
But regardless of how they interact with the UI, the focus indicator should
always indicate the foc
On Mon, 28 Oct 2024 19:20:28 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/
On Tue, 29 Oct 2024 17:44:21 GMT, Andy Goryachev wrote:
> A general question: what would be an example of when `focused !=
> focusVisible` (and `!= focusWithin`) ?
>
> Shouldn't the `focused` be a sort of "primary" property, and all other
> derived from it?
>
> What is the purpose of `focusVi
On Mon, 28 Oct 2024 19:20:28 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/
> Public focus traversal API for use in custom controls
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
>
> And is a scaled down version (with the public trav
15 matches
Mail list logo
