Re: Promote addEventHandler/removeEventHandler to EventTarget interface

2023-04-14 Thread Kevin Rushforth
enjfx-dev on behalf of Michael Strauß *Date: *Wednesday, April 12, 2023 at 12:05 *To: *Kevin Rushforth *Cc: *openjfx-dev@openjdk.org *Subject: *Re: Promote addEventHandler/removeEventHandler to EventTarget interface I've created a draft PR with the proposed changes: https://github.com/o

Aw: Re: Promote addEventHandler/removeEventHandler to EventTarget interface

2023-04-14 Thread Marius Hanl
2023 um 21:04 Uhr Von: "Michael Strauß" An: "Kevin Rushforth" Cc: openjfx-dev@openjdk.org Betreff: Re: Promote addEventHandler/removeEventHandler to EventTarget interface I've created a draft PR with the proposed changes: https://github.com/openjdk/jfx/pull/1090 Adding

Re: Promote addEventHandler/removeEventHandler to EventTarget interface

2023-04-13 Thread Andy Goryachev
enjfx-dev@openjdk.org Subject: Re: Promote addEventHandler/removeEventHandler to EventTarget interface I've created a draft PR with the proposed changes: https://github.com/openjdk/jfx/pull/1090 Adding event handler management methods to `EventTarget` greatly increases the usefulness of the ev

Re: Promote addEventHandler/removeEventHandler to EventTarget interface

2023-04-12 Thread Michael Strauß
I've created a draft PR with the proposed changes: https://github.com/openjdk/jfx/pull/1090 Adding event handler management methods to `EventTarget` greatly increases the usefulness of the event system for the reasons John and I mentioned earlier. I want to circle back to the compatibility issues

Re: Promote addEventHandler/removeEventHandler to EventTarget interface

2023-03-07 Thread Kevin Rushforth
An incompatible change in a fundamental interface such as EventTarget is not something we would want to do, so any proposed changes will need to retain compatibility (both binary and source). At a minimum, this means that any newly added methods would need to have a default implementation, and

Re: Promote addEventHandler/removeEventHandler to EventTarget interface

2023-03-07 Thread John Hendrikx
Hi Michael, Did you file a JIRA issue for this one? I've recently also been doing some rewriting to use the Event system more.  I'm removing custom Scene walking code (and looking at Node.getProperties) to do "event handling", and I've now discovered that it could be done quite a bit nicer b

Re: Promote addEventHandler/removeEventHandler to EventTarget interface

2023-03-07 Thread John Hendrikx
Hi Michael, Did you file a JIRA issue for this one? I've recently also been doing some rewriting to use the Event system more.  I'm removing custom Scene walking code (and looking at Node.getProperties) to do "event handling", and I've now discovered that it could be done quite a bit nicer by