Re: ESC key binding on the Scene

2023-11-25 Thread Martin Fox
Thiago, I’ve tested several modal dialogs on Mac, Windows, and Linux and in all but one ESC always dismisses the dialog. The only way for a user to back out an edit is to use Undo. The exception was the standard open file dialog on the Mac. In that dialog the Search field behaves the way you pr

Re: ESC key binding on the Scene

2023-11-21 Thread John Hendrikx
IMHO, FX should not be consuming keys when they do nothing. Navigation keys are also always consumed (cursor keys + TAB), even when focus did not change. I think this is because of the auto consume flag being set on many key bindings, while those bindings often have another condition in their

Re: [External] : Re: ESC key binding on the Scene

2023-11-21 Thread Andy Goryachev
Created https://bugs.openjdk.org/browse/JDK-8320557 Feel free to add additional details. -andy From: openjfx-dev on behalf of Andy Goryachev Date: Tuesday, November 21, 2023 at 12:39 To: Thiago Milczarek Sayão Cc: openjfx-dev Subject: Re: [External] : Re: ESC key binding on the Scene So

Re: [External] : Re: ESC key binding on the Scene

2023-11-21 Thread Andy Goryachev
Milczarek Sayão Date: Tuesday, November 21, 2023 at 12:14 To: Andy Goryachev Cc: openjfx-dev Subject: [External] : Re: ESC key binding on the Scene Andy, I think you're right about the formatter. The idea was to let the key propagate if there's nothing to cancel. For example: If

Re: ESC key binding on the Scene

2023-11-21 Thread Thiago Milczarek Sayão
Andy, I think you're right about the formatter. The idea was to let the key propagate if there's nothing to cancel. For example: If I want to cancel the edit, one ESC. The second ESC would propagate because there's nothing to cancel. Thank you for the reply. Em ter., 21 de nov. de 2023 às 14

Re: ESC key binding on the Scene

2023-11-21 Thread Andy Goryachev
Dear Thiago: I don’t think it’s related to undo but to a TextField with a formatter. The question is - do you want to disable the standard behavior (updating the text using the formatter on ESCAPE) completely? Or perhaps you do want to let TextField invoke cancelEdit() (see TextInputControlBeh