Re: [External] : Re: Discussion: Naming API method

2022-11-23 Thread Kevin Rushforth
That seems reasonable to me, so let's stick with "when". -- Kevin On 11/21/2022 4:21 PM, John Hendrikx wrote: I'm still leaning towards just "when" mainly because its short and, although perhaps not 100% accurate, recognizable enough like `map` or `flatMap` would be.  I think once it is in

Re: [External] : Re: Discussion: Naming API method

2022-11-21 Thread John Hendrikx
I'm still leaning towards just "when" mainly because its short and, although perhaps not 100% accurate, recognizable enough like `map` or `flatMap` would be.  I think once it is in a bit more common use, it will be quite clear what it does and what it is intended for without needing to be remin

Re: [External] : Re: Discussion: Naming API method

2022-11-21 Thread Kevin Rushforth
Maybe "updatedWhen" would work, although I still like "activeWhen" or simply "when" better. The problem that has been raised about "updateWhen" is that it isn't really the right verb tense. What we want is a binding that is updated (or active) when the condition evaluates to true. The value its

Re: Discussion: Naming API method

2022-11-21 Thread Nir Lisker
My proposal in the PR was 'updateWhen', which I prefer over observedWhen and activeWhen. Just 'when' is also fine by me and prefered over 'when'. My only problem with 'when'/'whenever' is that they don't say what happens "when"/"whenever". However, since these are bindings, and what bindings do is

Re: Discussion: Naming API method

2022-11-21 Thread Kevin Rushforth
My initial reaction is that I like the name "activeWhen" at least as well as any of the alternatives discussed so far. It's less wordy than "observedWhen" (which I suggested), and probably easier to describe. I don't really care for using the term "scope". I also think "when" or "whenever" are

Re: Discussion: Naming API method

2022-11-21 Thread Scott Palmer
t; > -andy > > > > > > *From: *openjfx-dev on behalf of Kevin > Rushforth > *Date: *Monday, 2022/11/14 at 09:40 > *To: *openjfx-dev@openjdk.org > *Subject: *Re: Discussion: Naming API method > > I also think this will be a useful feature to get into Jav

Re: Discussion: Naming API method

2022-11-21 Thread Michael Strauß
Thanks for your clarifications. Maybe the actual problem is that we don't have a good name for "gets the current value, but doesn't subscribe to updates". We could call bindings "active" when changes of the source value are processed, and "inactive" if the binding exists, but doesn't process change

Re: Discussion: Naming API method

2022-11-21 Thread John Hendrikx
Hi Michael, Thanks for your suggestion. The effect is not quite what you describe however, as the initial value when the operation is first invoked is retained. It's true however that when the condition is always `false` that the value will be a constant, and that when it is always `true` it

Re: Discussion: Naming API method

2022-11-15 Thread Michael Strauß
The new operation returns a new ObservableValue that is only meaningfully "exists" when the condition holds. If the condition doesn't hold, the effect is as if the operation wasn't invoked at all, i.e. it doesn't meaningfully exist. With this in mind, here's another option: label.textProperty().bi

Re: Discussion: Naming API method

2022-11-15 Thread Kevin Rushforth
like an update, which I think it is not.  "when" seems too vague. Disclaimer: English is not my native language. -andy *From: *openjfx-dev on behalf of Kevin Rushforth *Date: *Monday, 2022/11/14 at 09:40 *To: *openjfx-dev@openjdk.org *Subject: *Re: Discussion: Naming API method I

Re: Discussion: Naming API method

2022-11-14 Thread Andy Goryachev
22/11/14 at 09:40 To: openjfx-dev@openjdk.org Subject: Re: Discussion: Naming API method I also think this will be a useful feature to get into JavaFX. As for the name of the method, the only one of them I don't like is "conditionOn". That name doesn't suggest (to me anyway) wha

Re: Discussion: Naming API method

2022-11-14 Thread Kevin Rushforth
I also think this will be a useful feature to get into JavaFX. As for the name of the method, the only one of them I don't like is "conditionOn". That name doesn't suggest (to me anyway) what its purpose is. I think any of the ones with "when" in the name would work. I have a slight preference