On Wed, 3 Jan 2024 01:14:13 GMT, John Hendrikx wrote:
> The regression is caused by the `Collections.unmodifiableSet` wrapper not
> being recognized by `BitSet`, and a fall back is done to a less optimized
> version of `containsAll`.
>
> As this is a regression fix, I've kept the fix as small
On Wed, 3 Jan 2024 18:33:29 GMT, Kevin Rushforth wrote:
>> The regression is caused by the `Collections.unmodifiableSet` wrapper not
>> being recognized by `BitSet`, and a fall back is done to a less optimized
>> version of `containsAll`.
>>
>> As this is a regression fix, I've kept the fix as
On Wed, 3 Jan 2024 01:14:13 GMT, John Hendrikx wrote:
> The regression is caused by the `Collections.unmodifiableSet` wrapper not
> being recognized by `BitSet`, and a fall back is done to a less optimized
> version of `containsAll`.
>
> As this is a regression fix, I've kept the fix as small
On Wed, 3 Jan 2024 01:14:13 GMT, John Hendrikx wrote:
> The regression is caused by the `Collections.unmodifiableSet` wrapper not
> being recognized by `BitSet`, and a fall back is done to a less optimized
> version of `containsAll`.
>
> As this is a regression fix, I've kept the fix as small
On Wed, 3 Jan 2024 01:14:13 GMT, John Hendrikx wrote:
> As this is a regression fix, I've kept the fix as small as reasonable
Thanks. That seems like the best solution.
-
PR Comment: https://git.openjdk.org/jfx/pull/1314#issuecomment-1875796318
The regression is caused by the `Collections.unmodifiableSet` wrapper not being
recognized by `BitSet`, and a fall back is done to a less optimized version of
`containsAll`.
As this is a regression fix, I've kept the fix as small as reasonable. I'll
provide a further optimized version as part
