On Fri, 22 Sep 2023 10:11:12 GMT, Marius Hanl wrote:
>> This PR adds a test that verifies the `SkinBase.layoutChildren(..)` method
>> with different scales.
>> While not explicitly documented, this method will receive the snapped and
>> correctly calculated x, y, width and height values, so tha
On Fri, 22 Sep 2023 17:14:30 GMT, Andy Goryachev wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8315569: Improve test name and add 2.25 scale
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/
On Fri, 22 Sep 2023 10:11:12 GMT, Marius Hanl wrote:
>> This PR adds a test that verifies the `SkinBase.layoutChildren(..)` method
>> with different scales.
>> While not explicitly documented, this method will receive the snapped and
>> correctly calculated x, y, width and height values, so tha
> This PR adds a test that verifies the `SkinBase.layoutChildren(..)` method
> with different scales.
> While not explicitly documented, this method will receive the snapped and
> correctly calculated x, y, width and height values, so that children of the
> Control can be layouted correctly with
On Tue, 12 Sep 2023 22:48:26 GMT, Andy Goryachev wrote:
>> Do you a better idea? I guess it would make sense to rename it to something
>> more generic. Maybe ControlLayoutTest?
>
> ControlLayoutChildrenContractTest perhaps, if that's the only thing being
> tested here (that is, if you don't pla
On Tue, 12 Sep 2023 07:07:27 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlContractTest.java
>> line 44:
>>
>>> 42: import static org.junit.jupiter.api.Assertions.assertTrue;
>>> 43:
>>> 44: class ControlContractTest {
>>
>> Do you plan to a
On Thu, 7 Sep 2023 22:04:46 GMT, Andy Goryachev wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8315569: Set a min size
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlContractTest.jav
On Sat, 2 Sep 2023 13:09:14 GMT, Marius Hanl wrote:
>> This PR adds a test that verifies the `SkinBase.layoutChildren(..)` method
>> with different scales.
>> While not explicitly documented, this method will receive the snapped and
>> correctly calculated x, y, width and height values, so that
On Sat, 2 Sep 2023 13:09:14 GMT, Marius Hanl wrote:
>> This PR adds a test that verifies the `SkinBase.layoutChildren(..)` method
>> with different scales.
>> While not explicitly documented, this method will receive the snapped and
>> correctly calculated x, y, width and height values, so that
> This PR adds a test that verifies the `SkinBase.layoutChildren(..)` method
> with different scales.
> While not explicitly documented, this method will receive the snapped and
> correctly calculated x, y, width and height values, so that children of the
> Control can be layouted correctly with
This PR adds a test that verifies the `SkinBase.layoutChildren(..)` method with
different scales.
While not explicitly documented, this method will receive the snapped and
correctly calculated x, y, width and height values, so that children of the
Control can be layouted correctly without requir
11 matches
Mail list logo
