On Mon, 21 Nov 2022 23:59:51 GMT, Andy Goryachev wrote:
> > Just making sure, I can integrate this now?
>
> format requirements have been fulfilled (1 reviewer, 1 author). go!
Yes, this one was ready to go, thanks for checking.
As a general comment, and not specific to this review, I want to r
On Mon, 21 Nov 2022 23:50:58 GMT, John Hendrikx wrote:
> Just making sure, I can integrate this now?
format requirements have been fulfilled (1 reviewer, 1 author). go!
-
PR: https://git.openjdk.org/jfx/pull/957
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
On Mon, 21 Nov 2022 22:28:15 GMT, Kevin Rushforth wrote:
> treating certain categories of warnings as errors at compilation time is
> quite feasible. The JDK does this.
I have "missing override annotations" set to errors in my projects. I think
it's a good candidate here.
-
PR: h
On Mon, 21 Nov 2022 15:24:24 GMT, Kevin Rushforth wrote:
> One other quick comment: since you are removing some suppress warnings for
> "removal", I'd like to see the results of a build and test with `gradle
> -PLINT=removal` to ensure that there are no new warnings.
I've run this locally, and
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
On Mon, 21 Nov 2022 22:36:05 GMT, Kevin Rushforth wrote:
>> let's create a followup ticket - the messed up statements in Disposer and
>> especially in PrismFontFactory:1401 are worrying.
>>
>> cc: @prrace
>
> @andy-goryachev-oracle The ones in the various `Disposer` classes and
> `PrismFontFac
On Mon, 21 Nov 2022 20:05:25 GMT, John Hendrikx wrote:
>> Removing the `(int)` cast is a behavior-neutral change. What you are
>> pointing out does look a bug, but it is unrelated to this cleanup, so should
>> be filed and fixed separately.
>
> Yeah, this looks like a bug, as `(steps - counter)
On Mon, 21 Nov 2022 20:49:07 GMT, Andy Goryachev wrote:
>> but the ticket specifies (javafx.)base, right?
>
> let's create a followup ticket - the messed up statements in Disposer and
> especially in PrismFontFactory:1401 are worrying.
>
> cc: @prrace
@andy-goryachev-oracle The ones in the var
On Mon, 21 Nov 2022 20:34:02 GMT, John Hendrikx wrote:
> I think the Skara tooling might be able to reject PR's with warnings, if not,
> Gradle can fail builds with warnings (but that's a bit more heavy handed).
Quite the opposite. This would be well beyond Skara to do this (and I would
argue
On Mon, 21 Nov 2022 20:21:23 GMT, Andy Goryachev wrote:
>> Shims are not public as far as I know.
>
> you are right. I just looked at the package "package javafx.event;" and said
> hmmm...
And _thank you_ for doing that. That's exactly the sort of thing we would want
to catch if it were part
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
On Mon, 21 Nov 2022 21:06:53 GMT, Nir Lisker wrote:
>> let's create a followup ticket - the messed up statements in Disposer and
>> especially in PrismFontFactory:1401 are worrying.
>>
>> cc: @prrace
>
> All of the bugs in the list are not in the base module. We are slicing the
> work both per
On Mon, 21 Nov 2022 20:49:07 GMT, Andy Goryachev wrote:
>> but the ticket specifies (javafx.)base, right?
>
> let's create a followup ticket - the messed up statements in Disposer and
> especially in PrismFontFactory:1401 are worrying.
>
> cc: @prrace
All of the bugs in the list are not in the
15 matches
Mail list logo
