Re: RFR: JDK-8218745: TableView: visual glitch at borders on horizontal scrolling

2024-03-10 Thread Marius Hanl
On Wed, 10 Jan 2024 19:21:16 GMT, Marius Hanl wrote: > This PR fixes the border glitch/gap as explained in both linked tickets. > > I noted that the `ScrollPane` control does not suffer from this problem, > although the code is mostly the same as in `VirtualFlow`. The `ScrollPane` > snaps the

Re: RFR: JDK-8218745: TableView: visual glitch at borders on horizontal scrolling

2024-03-09 Thread Marius Hanl
On Wed, 10 Jan 2024 19:21:16 GMT, Marius Hanl wrote: > This PR fixes the border glitch/gap as explained in both linked tickets. > > I noted that the `ScrollPane` control does not suffer from this problem, > although the code is mostly the same as in `VirtualFlow`. The `ScrollPane` > snaps the

Re: RFR: JDK-8218745: TableView: visual glitch at borders on horizontal scrolling

2024-01-12 Thread Kevin Rushforth
On Wed, 10 Jan 2024 22:39:22 GMT, Andy Goryachev wrote: >> This PR fixes the border glitch/gap as explained in both linked tickets. >> >> I noted that the `ScrollPane` control does not suffer from this problem, >> although the code is mostly the same as in `VirtualFlow`. The `ScrollPane` >> sn

Re: RFR: JDK-8218745: TableView: visual glitch at borders on horizontal scrolling

2024-01-11 Thread Andy Goryachev
On Wed, 10 Jan 2024 19:21:16 GMT, Marius Hanl wrote: > This PR fixes the border glitch/gap as explained in both linked tickets. > > I noted that the `ScrollPane` control does not suffer from this problem, > although the code is mostly the same as in `VirtualFlow`. The `ScrollPane` > snaps the

Re: RFR: JDK-8218745: TableView: visual glitch at borders on horizontal scrolling

2024-01-11 Thread Marius Hanl
On Wed, 10 Jan 2024 23:57:24 GMT, Andy Goryachev wrote: > It might be a dumb question: would it be possible to avoid creating an > intermediate container and keep the existing .css files? Not a dumb question, that is what I tried at first. See also my old PR: https://github.com/openjdk/jfx/pul

Re: RFR: JDK-8218745: TableView: visual glitch at borders on horizontal scrolling

2024-01-10 Thread Andy Goryachev
On Wed, 10 Jan 2024 19:21:16 GMT, Marius Hanl wrote: > This PR fixes the border glitch/gap as explained in both linked tickets. > > I noted that the `ScrollPane` control does not suffer from this problem, > although the code is mostly the same as in `VirtualFlow`. The `ScrollPane` > snaps the

Re: RFR: JDK-8218745: TableView: visual glitch at borders on horizontal scrolling

2024-01-10 Thread Andy Goryachev
On Wed, 10 Jan 2024 19:21:16 GMT, Marius Hanl wrote: > This PR fixes the border glitch/gap as explained in both linked tickets. > > I noted that the `ScrollPane` control does not suffer from this problem, > although the code is mostly the same as in `VirtualFlow`. The `ScrollPane` > snaps the

Re: RFR: JDK-8218745: TableView: visual glitch at borders on horizontal scrolling

2024-01-10 Thread Kevin Rushforth
On Wed, 10 Jan 2024 19:21:16 GMT, Marius Hanl wrote: > This PR fixes the border glitch/gap as explained in both linked tickets. > > I noted that the `ScrollPane` control does not suffer from this problem, > although the code is mostly the same as in `VirtualFlow`. The `ScrollPane` > snaps the

RFR: JDK-8218745: TableView: visual glitch at borders on horizontal scrolling

2024-01-10 Thread Marius Hanl
This PR fixes the border glitch/gap as explained in both linked tickets. I noted that the `ScrollPane` control does not suffer from this problem, although the code is mostly the same as in `VirtualFlow`. The `ScrollPane` snaps the content correctly, no matter which scale. I carefully checked the