On Mon, 16 Jun 2025 05:30:53 GMT, Ambarish Rapte wrote:
> > Noticed that when the buttons show pages 11-20, the focus is on button 13,
> > it announces "you are currently on selected page, group, 3 of 10"
>
> This is observed on windows too. Seems like an existing issue, may be we
> should rep
On Mon, 16 Jun 2025 05:52:53 GMT, Ambarish Rapte wrote:
> May be can change these methods to have a helper method.
I will probably do this refactoring in a separate PR.
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1823#discussion_r2150468463
On Thu, 12 Jun 2025 20:46:49 GMT, Alexander Zuev wrote:
>> Create implementation of the TabGroup protocol and assign it to TAB_PANE and
>> PAGINATION roles.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add accessible
On Thu, 12 Jun 2025 20:46:49 GMT, Alexander Zuev wrote:
>> Create implementation of the TabGroup protocol and assign it to TAB_PANE and
>> PAGINATION roles.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add accessible
On Thu, 12 Jun 2025 22:48:04 GMT, Andy Goryachev wrote:
> Noticed that when the buttons show pages 11-20, the focus is on button 13, it
> announces "you are currently on selected page, group, 3 of 10"
This is observed on windows too. Seems like an existing issue, may be we should
report an iss
On Thu, 12 Jun 2025 22:53:11 GMT, Andy Goryachev wrote:
> TabPane: can't find any differences between this PR and the master. What
> should it say differently?
Nothing. TabPane should behave exactly the same. I need to check what's going
on with pagination, but i do not think it is changed fro
On Thu, 12 Jun 2025 20:46:49 GMT, Alexander Zuev wrote:
>> Create implementation of the TabGroup protocol and assign it to TAB_PANE and
>> PAGINATION roles.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add accessible
On Thu, 12 Jun 2025 20:46:49 GMT, Alexander Zuev wrote:
>> Create implementation of the TabGroup protocol and assign it to TAB_PANE and
>> PAGINATION roles.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add accessible
On Thu, 12 Jun 2025 19:23:57 GMT, Andy Goryachev wrote:
> Also noticed to pre-existing issues (in master):
>
> * resizing the control does not update the accessibility focus rectangle
> * flipping through tabs in TabPane using left/right arrow keys sometimes
> places the accessibility focus rec
> Create implementation of the TabGroup protocol and assign it to TAB_PANE and
> PAGINATION roles.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Add accessible role description to the base component
-
Changes:
- a
On Thu, 12 Jun 2025 18:36:31 GMT, Alexander Zuev wrote:
>> Create implementation of the TabGroup protocol and assign it to TAB_PANE and
>> PAGINATION roles.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixing indentat
On Thu, 12 Jun 2025 18:36:31 GMT, Alexander Zuev wrote:
>> Create implementation of the TabGroup protocol and assign it to TAB_PANE and
>> PAGINATION roles.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixing indentat
On Thu, 12 Jun 2025 18:36:31 GMT, Alexander Zuev wrote:
>> Create implementation of the TabGroup protocol and assign it to TAB_PANE and
>> PAGINATION roles.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixing indentat
On Wed, 11 Jun 2025 21:51:46 GMT, Andy Goryachev wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixing indentation.
>
> modules/javafx.graphics/src/main/native-glass/mac/a11y/JFXTabGroupAccessibility.m
> line 5
> Create implementation of the TabGroup protocol and assign it to TAB_PANE and
> PAGINATION roles.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Fixing indentation.
-
Changes:
- all: https://git.openjdk.org/jfx/pu
On Wed, 11 Jun 2025 21:13:12 GMT, Alexander Zuev wrote:
> Create implementation of the TabGroup protocol and assign it to TAB_PANE and
> PAGINATION roles.
modules/javafx.graphics/src/main/native-glass/mac/a11y/JFXTabGroupAccessibility.m
line 57:
> 55: if (env == NULL) return NULL;
> 56:
On Wed, 11 Jun 2025 21:13:12 GMT, Alexander Zuev wrote:
> Create implementation of the TabGroup protocol and assign it to TAB_PANE and
> PAGINATION roles.
Reviewers: @arapte @andy-goryachev-oracle
-
PR Comment: https://git.openjdk.org/jfx/pull/1823#issuecomment-2964380880
On Wed, 11 Jun 2025 21:13:12 GMT, Alexander Zuev wrote:
> Create implementation of the TabGroup protocol and assign it to TAB_PANE and
> PAGINATION roles.
In order to validate the fix one can use Ensemble8 demo app and go trough the
Pagination and TabPane controls, then check that with VoiceOv
Create implementation of the TabGroup protocol and assign it to TAB_PANE and
PAGINATION roles.
-
Commit messages:
- 8359257: Create accessibility protocol for TabGroup component
Changes: https://git.openjdk.org/jfx/pull/1823/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=
19 matches
Mail list logo
