Re: RFR: 8354702: [TestBug] LocalDateTimeStringConverterTest Workaround can be removed

2025-04-18 Thread Marius Hanl
On Thu, 17 Apr 2025 18:09:57 GMT, Andy Goryachev wrote: > both tickets are a duplicate of https://bugs.openjdk.org/browse/JDK-8264061 > fixed in jfx17, closed both. thanks! I don't want to close them when I was just testing them! So thank you for validating both tickets! :) - PR

Re: RFR: 8354702: [TestBug] LocalDateTimeStringConverterTest Workaround can be removed

2025-04-17 Thread Andy Goryachev
On Wed, 16 Apr 2025 08:31:16 GMT, Marius Hanl wrote: > close those tickets? both tickets are a duplicate of https://bugs.openjdk.org/browse/JDK-8264061 fixed in jfx17, closed both. thanks! - PR Comment: https://git.openjdk.org/jfx/pull/1778#issuecomment-2813698480

Re: RFR: 8354702: [TestBug] LocalDateTimeStringConverterTest Workaround can be removed

2025-04-16 Thread Andy Goryachev
On Wed, 16 Apr 2025 08:31:16 GMT, Marius Hanl wrote: > check the two other tickets will do! - PR Comment: https://git.openjdk.org/jfx/pull/1778#issuecomment-2809801813

Re: RFR: 8354702: [TestBug] LocalDateTimeStringConverterTest Workaround can be removed

2025-04-16 Thread Marius Hanl
On Tue, 15 Apr 2025 22:19:24 GMT, Kevin Rushforth wrote: > Yes, I would prefer a new JBS ticket. It would be OK to combine that as part > of this PR, since both are test fixes touching the same file. It would also > be OK to leave it for another day. Either is fine. I created [JDK-8354794](htt

Re: RFR: 8354702: [TestBug] LocalDateTimeStringConverterTest Workaround can be removed

2025-04-15 Thread Kevin Rushforth
On Tue, 15 Apr 2025 20:35:57 GMT, Andy Goryachev wrote: > Looks good. > > Unrelated note: the last three tests should not be parameterized since they > seem to be testing specific conditions (we missed this during the review). > > Since this is a test, we could fix it as a part of this PR, tho

Re: RFR: 8354702: [TestBug] LocalDateTimeStringConverterTest Workaround can be removed

2025-04-15 Thread Andy Goryachev
On Tue, 15 Apr 2025 20:16:04 GMT, Marius Hanl wrote: > [JDK-8297316](https://bugs.openjdk.org/browse/JDK-8297316) added a Workaround > for the Japanese Date Converter, which is different on JDK20 and newer. Since > our Boot JDK is Java 22 as of April 2025, we can remove the workaround. > > We

RFR: 8354702: [TestBug] LocalDateTimeStringConverterTest Workaround can be removed

2025-04-15 Thread Marius Hanl
[JDK-8297316](https://bugs.openjdk.org/browse/JDK-8297316) added a Workaround for the Japanese Date Converter, which is different on JDK20 and newer. Since our Boot JDK is Java 22 as of April 2025, we can remove the workaround. We should also consider testing and closing: [JDK-8265727](https://