Re: RFR: 8354478: Improve StageStyle documentation [v3]

2025-04-23 Thread Lukasz Kostyra
On Mon, 14 Apr 2025 23:25:57 GMT, Thiago Milczarek Sayao wrote: >> Improve StageStyle Documentation >> >> - Update `StageStyle.UTILITY`: >> Clarified that UTILITY stages may impose platform-specific restrictions on >> window states, such as preventing maximize, minimize (iconify), and >> full

Re: RFR: 8354478: Improve StageStyle documentation [v3]

2025-04-16 Thread Thiago Milczarek Sayao
On Wed, 16 Apr 2025 08:56:26 GMT, John Hendrikx wrote: >> Sure. I'll look into it. > > To be honest, I don't understand why we specify this at all. "white" surely > won't be the default when running on dark theme... I'm pretty sure on Windows > it isn't even white, it's some light gray. When

Re: RFR: 8354478: Improve StageStyle documentation [v3]

2025-04-16 Thread John Hendrikx
On Tue, 15 Apr 2025 17:18:48 GMT, Thiago Milczarek Sayao wrote: >> If it's a bug, could you please create a JBS ticket? > > Sure. I'll look into it. To be honest, I don't understand why we specify this at all. "white" surely won't be the default when running on dark theme... I'm pretty sure o

Re: RFR: 8354478: Improve StageStyle documentation [v3]

2025-04-15 Thread Thiago Milczarek Sayao
On Tue, 15 Apr 2025 14:52:10 GMT, Andy Goryachev wrote: >> I restored it, I think it's a Linux glass specific bug. > > If it's a bug, could you please create a JBS ticket? Sure. I'll look into it. - PR Review Comment: https://git.openjdk.org/jfx/pull/1776#discussion_r2045115036

Re: RFR: 8354478: Improve StageStyle documentation [v3]

2025-04-15 Thread Andy Goryachev
On Mon, 14 Apr 2025 23:39:46 GMT, Thiago Milczarek Sayao wrote: >> modules/javafx.graphics/src/main/java/javafx/stage/StageStyle.java line 35: >> >>> 33: >>> 34: /** >>> 35: * Defines a normal {@code Stage} style with a solid background and >>> platform decorations. >> >> Should we

Re: RFR: 8354478: Improve StageStyle documentation

2025-04-15 Thread Andy Goryachev
On Mon, 14 Apr 2025 13:29:08 GMT, John Hendrikx wrote: >> Improve StageStyle Documentation >> >> - Update `StageStyle.UTILITY`: >> Clarified that UTILITY stages may impose platform-specific restrictions on >> window states, such as preventing maximize, minimize (iconify), and >> fullscreen ope

Re: RFR: 8354478: Improve StageStyle documentation [v3]

2025-04-15 Thread Andy Goryachev
On Mon, 14 Apr 2025 23:25:57 GMT, Thiago Milczarek Sayao wrote: >> Improve StageStyle Documentation >> >> - Update `StageStyle.UTILITY`: >> Clarified that UTILITY stages may impose platform-specific restrictions on >> window states, such as preventing maximize, minimize (iconify), and >> full

Re: RFR: 8354478: Improve StageStyle documentation [v2]

2025-04-14 Thread Thiago Milczarek Sayao
On Mon, 14 Apr 2025 23:38:36 GMT, Thiago Milczarek Sayao wrote: >> modules/javafx.graphics/src/main/java/javafx/stage/StageStyle.java line 41: >> >>> 39: /** >>> 40: * Defines a {@code Stage} style with no window decorations, such >>> as a title bar, >>> 41: * borders, or window

Re: RFR: 8354478: Improve StageStyle documentation [v2]

2025-04-14 Thread Thiago Milczarek Sayao
On Mon, 14 Apr 2025 16:00:10 GMT, Nir Lisker wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Add "style" ib the UTILITY style like the others >> - Update modules/javafx.graphics/src/main/java/javafx/st

Re: RFR: 8354478: Improve StageStyle documentation [v3]

2025-04-14 Thread Thiago Milczarek Sayao
On Mon, 14 Apr 2025 14:36:13 GMT, Andy Goryachev wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Restore "with a solid white background" > > modules/javafx.graphics/src/main/java/javafx/stage/StageStyle.j

Re: RFR: 8354478: Improve StageStyle documentation [v3]

2025-04-14 Thread Thiago Milczarek Sayao
> Improve StageStyle Documentation > > - Update `StageStyle.UTILITY`: > Clarified that UTILITY stages may impose platform-specific restrictions on > window states, such as preventing maximize, minimize (iconify), and > fullscreen operations. > > - Update `StageStyle.UNDECORATED`: > Improved the

Re: RFR: 8354478: Improve StageStyle documentation [v2]

2025-04-14 Thread Thiago Milczarek Sayao
> Improve StageStyle Documentation > > - Update `StageStyle.UTILITY`: > Clarified that UTILITY stages may impose platform-specific restrictions on > window states, such as preventing maximize, minimize (iconify), and > fullscreen operations. > > - Update `StageStyle.UNDECORATED`: > Improved the

Re: RFR: 8354478: Improve StageStyle documentation

2025-04-14 Thread Nir Lisker
On Sun, 13 Apr 2025 15:24:43 GMT, Thiago Milczarek Sayao wrote: > Improve StageStyle Documentation > > - Update `StageStyle.UTILITY`: > Clarified that UTILITY stages may impose platform-specific restrictions on > window states, such as preventing maximize, minimize (iconify), and > fullscreen

Re: RFR: 8354478: Improve StageStyle documentation [v2]

2025-04-14 Thread Nir Lisker
On Mon, 14 Apr 2025 15:13:19 GMT, Thiago Milczarek Sayao wrote: >> Improve StageStyle Documentation >> >> - Update `StageStyle.UTILITY`: >> Clarified that UTILITY stages may impose platform-specific restrictions on >> window states, such as preventing maximize, minimize (iconify), and >> full

Re: RFR: 8354478: Improve StageStyle documentation

2025-04-14 Thread Lukasz Kostyra
On Sun, 13 Apr 2025 15:24:43 GMT, Thiago Milczarek Sayao wrote: > Improve StageStyle Documentation > > - Update `StageStyle.UTILITY`: > Clarified that UTILITY stages may impose platform-specific restrictions on > window states, such as preventing maximize, minimize (iconify), and > fullscreen

Re: RFR: 8354478: Improve StageStyle documentation

2025-04-14 Thread Andy Goryachev
On Sun, 13 Apr 2025 15:24:43 GMT, Thiago Milczarek Sayao wrote: > Improve StageStyle Documentation > > - Update `StageStyle.UTILITY`: > Clarified that UTILITY stages may impose platform-specific restrictions on > window states, such as preventing maximize, minimize (iconify), and > fullscreen

Re: RFR: 8354478: Improve StageStyle documentation

2025-04-14 Thread John Hendrikx
On Sun, 13 Apr 2025 15:24:43 GMT, Thiago Milczarek Sayao wrote: > Improve StageStyle Documentation > > - Update `StageStyle.UTILITY`: > Clarified that UTILITY stages may impose platform-specific restrictions on > window states, such as preventing maximize, minimize (iconify), and > fullscreen

RFR: 8354478: Improve StageStyle documentation

2025-04-13 Thread Thiago Milczarek Sayao
Improve StageStyle Documentation - Update `StageStyle.UTILITY`: Clarified that UTILITY stages may impose platform-specific restrictions on window states, such as preventing maximize, minimize (iconify), and fullscreen operations. - Update `StageStyle.UNDECORATED`: Improved the description to cl